From: Milan Broz <mbroz@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
Kernel Team <kernel-team@lists.ubuntu.com>,
linux-kernel@vger.kernel.org, jgarzik@redhat.com,
JBottomley@Parallels.com
Subject: [PATCH] dm-crypt: never use write same (was Re: [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME)
Date: Wed, 19 Dec 2012 22:07:11 +0100 [thread overview]
Message-ID: <50D22C7F.2020201@redhat.com> (raw)
In-Reply-To: <50D22766.9090107@redhat.com>
Does this help?
dm-crypt: never use write same
Ciphertext device is not compatible with WRITE SAME,
disable it for all dmcrypt devices.
Signed-off-by: Milan Broz <mbroz@redhat.com>
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1844,6 +1844,12 @@ static int crypt_iterate_devices(struct dm_target *ti,
return fn(ti, cc->dev, cc->start, ti->len, data);
}
+static void crypt_io_hints(struct dm_target *ti,
+ struct queue_limits *limits)
+{
+ limits->max_write_same_sectors = 0;
+}
+
static struct target_type crypt_target = {
.name = "crypt",
.version = {1, 11, 0},
@@ -1858,6 +1864,7 @@ static struct target_type crypt_target = {
.message = crypt_message,
.merge = crypt_merge,
.iterate_devices = crypt_iterate_devices,
+ .io_hints = crypt_io_hints,
};
static int __init dm_crypt_init(void)
next prev parent reply other threads:[~2012-12-19 21:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 20:30 [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME Joseph Salisbury
2012-12-14 21:11 ` Mike Snitzer
2012-12-15 2:38 ` Joseph Salisbury
2012-12-14 22:35 ` Martin K. Petersen
2012-12-15 2:40 ` Joseph Salisbury
2012-12-18 19:52 ` Joseph Salisbury
2012-12-19 16:58 ` Martin K. Petersen
2012-12-19 19:58 ` Mike Snitzer
2012-12-19 19:59 ` Joseph Salisbury
2012-12-19 20:45 ` Martin K. Petersen
2012-12-19 20:45 ` Martin K. Petersen
2012-12-19 20:45 ` Milan Broz
2012-12-19 21:07 ` Milan Broz [this message]
2012-12-19 21:07 ` [PATCH] dm-crypt: never use write same (was Re: [v3.7 Regression] [SCSI] sd: Implement support for WRITE SAME) Joseph Salisbury
2012-12-19 22:20 ` Joseph Salisbury
2012-12-19 22:23 ` Milan Broz
2015-07-13 16:33 ` Joseph Salisbury
2015-07-13 16:59 ` Milan Broz
2015-07-13 17:01 ` Milan Broz
2015-07-13 18:01 ` Mike Snitzer
2012-12-20 0:11 ` [PATCH] " Martin K. Petersen
2012-12-20 5:47 ` Mike Snitzer
2012-12-20 5:57 ` [PATCH 1/4] dm: default to disabling WRITE SAME support for all targets Mike Snitzer
2012-12-20 5:57 ` [PATCH 2/4] dm: add WRITE SAME support Mike Snitzer
2012-12-20 5:57 ` [PATCH 3/4] dm linear: " Mike Snitzer
2012-12-20 5:57 ` [PATCH 4/4] dm stripe: " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D22C7F.2020201@redhat.com \
--to=mbroz@redhat.com \
--cc=JBottomley@Parallels.com \
--cc=jgarzik@redhat.com \
--cc=joseph.salisbury@canonical.com \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.