Re: [LTP] [PATCH] Add check_simple_capset in filecapstest.sh.

Re: [LTP] [PATCH] Add check_simple_capset in filecapstest.sh.

[Cyril Hrubis]

Hi!
> +echo "testing for simple capset"
> +check_simple_capset
> +tmp=$?
> +if [ $tmp -ne 0 ]; then
> +	exit_code=$tmp
> +fi

Rather than adding to the script, can we split it so that each of the
binaries can be run separately and that we have one entry per test in
the runtest file?

It would also be good idea to prefix the test binaris with capset_ or
something similar (in a separate patch please).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Add check_simple_capset in filecapstest.sh.

[Cyril Hrubis]

Hi!
> >> +echo "testing for simple capset"
> >> +check_simple_capset
> >> +tmp=$?
> >> +if [ $tmp -ne 0 ]; then
> >> +	exit_code=$tmp
> >> +fi
> > Rather than adding to the script, can we split it so that each of the
> > binaries can be run separately and that we have one entry per test in
> > the runtest file?
> You mean that I need to add check_simple_capset to ltp/runtest/filecaps. 
> Is it right?

Yes along with the rest of tests that are executed from the script and
move any required setup from the script to the testcases as well. Looks
to me like tst_tmpdir() would be needed but I haven't checked throughly.

Idealy we would have one record in runtest files per test.

> > It would also be good idea to prefix the test binaris with capset_ or
> > something similar (in a separate patch please).
> >
> The following file names need updating. Is it right?
> 
> check_simple_capset.c -> capset_check_simple.c
> inh_capped.c -> capset_inh.c
> print_caps.c -> capset_print.c
> verify_caps_exec.c -> capset_verify_exec.c

Yes please.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list