From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ian Molton <ian.molton@codethink.co.uk>
Subject: Re: [PATCH v2 0/5] enable I2C on Renesas EMEV2 and KZM9D board
Date: Tue, 14 Jul 2015 13:18:58 +0200 [thread overview]
Message-ID: <20150714111857.GC1517@katana> (raw)
In-Reply-To: <1436600786-3068-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]
On Sat, Jul 11, 2015 at 09:46:21AM +0200, Wolfram Sang wrote:
> So, I picked up the old series from Ian and reworked it significantly. While
> his series was already an improvement from the driver found in the BSP, it was
> still not ready for upstream. It should be now :) My idea was to start simple
> and improve incrementally, so e.g. clock handling was broken, so clocks are
> always on for starters. Major changes include:
>
> * clock handling simplified and adapted to current EMEV clock handling
> * switch from wait_event to completion mechanism. The old one was basically
> some kind of completion with custom code around wait_events
> * dropped using signals; they always cause trouble with I2C
> * simplified the bus free logic. If it turns out to be too simple, we'd need
> to switch to the bus_recovery infrastructure probably. But we'd need a test
> case for that
> * error handling improved to match subsystem standards
> * removed some BSP angst code
> * lots of refactoring to make code simpler, more readable...
> * bugfixes
>
> I also added all the glue code to add clocks, disable reset etc which was
> missing before. I'd prefer to take the first three patches via i2c myself,
> and the latter two via Simon's tree.
>
> Since V1, there are minor updates fixing issues found in reviews. Thanks!
>
> A branch for testing can be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/emma-i2c
>
> Please test, comment...
>
> Thanks!
>
> Wolfram
>
> Wolfram Sang (5):
> clk: shmobile: emev2: deassert reset for IIC0/1
> i2c: emev2: add binding documentation
> i2c: emev2: add driver
Those patches applied to for-next...
> ARM: shmobile: emev2: add IIC cores to dtsi
> ARM: shmobile: emev2: kzm9d: enable IIC busses
... so Simon, you can pick up these, I'd say.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ian Molton <ian.molton@codethink.co.uk>
Subject: Re: [PATCH v2 0/5] enable I2C on Renesas EMEV2 and KZM9D board
Date: Tue, 14 Jul 2015 11:18:58 +0000 [thread overview]
Message-ID: <20150714111857.GC1517@katana> (raw)
In-Reply-To: <1436600786-3068-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]
On Sat, Jul 11, 2015 at 09:46:21AM +0200, Wolfram Sang wrote:
> So, I picked up the old series from Ian and reworked it significantly. While
> his series was already an improvement from the driver found in the BSP, it was
> still not ready for upstream. It should be now :) My idea was to start simple
> and improve incrementally, so e.g. clock handling was broken, so clocks are
> always on for starters. Major changes include:
>
> * clock handling simplified and adapted to current EMEV clock handling
> * switch from wait_event to completion mechanism. The old one was basically
> some kind of completion with custom code around wait_events
> * dropped using signals; they always cause trouble with I2C
> * simplified the bus free logic. If it turns out to be too simple, we'd need
> to switch to the bus_recovery infrastructure probably. But we'd need a test
> case for that
> * error handling improved to match subsystem standards
> * removed some BSP angst code
> * lots of refactoring to make code simpler, more readable...
> * bugfixes
>
> I also added all the glue code to add clocks, disable reset etc which was
> missing before. I'd prefer to take the first three patches via i2c myself,
> and the latter two via Simon's tree.
>
> Since V1, there are minor updates fixing issues found in reviews. Thanks!
>
> A branch for testing can be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/emma-i2c
>
> Please test, comment...
>
> Thanks!
>
> Wolfram
>
> Wolfram Sang (5):
> clk: shmobile: emev2: deassert reset for IIC0/1
> i2c: emev2: add binding documentation
> i2c: emev2: add driver
Those patches applied to for-next...
> ARM: shmobile: emev2: add IIC cores to dtsi
> ARM: shmobile: emev2: kzm9d: enable IIC busses
... so Simon, you can pick up these, I'd say.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-14 11:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 7:46 [PATCH v2 0/5] enable I2C on Renesas EMEV2 and KZM9D board Wolfram Sang
2015-07-11 7:46 ` Wolfram Sang
2015-07-11 7:46 ` [PATCH v2 2/5] i2c: emev2: add binding documentation Wolfram Sang
2015-07-11 7:46 ` Wolfram Sang
[not found] ` <1436600786-3068-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-11 7:46 ` [PATCH v2 1/5] clk: shmobile: emev2: deassert reset for IIC0/1 Wolfram Sang
2015-07-11 7:46 ` Wolfram Sang
2015-07-11 7:46 ` [PATCH v2 3/5] i2c: emev2: add driver Wolfram Sang
2015-07-11 7:46 ` Wolfram Sang
2015-07-11 10:03 ` Wolfram Sang
2015-07-11 10:03 ` Wolfram Sang
2015-07-12 21:12 ` Laurent Pinchart
2015-07-12 21:12 ` Laurent Pinchart
2015-07-11 7:46 ` [PATCH v2 4/5] ARM: shmobile: emev2: add IIC cores to dtsi Wolfram Sang
2015-07-11 7:46 ` Wolfram Sang
2015-07-11 7:46 ` [PATCH v2 5/5] ARM: shmobile: emev2: kzm9d: enable IIC busses Wolfram Sang
2015-07-11 7:46 ` Wolfram Sang
2015-07-14 11:18 ` Wolfram Sang [this message]
2015-07-14 11:18 ` [PATCH v2 0/5] enable I2C on Renesas EMEV2 and KZM9D board Wolfram Sang
2015-07-15 0:12 ` Simon Horman
2015-07-15 0:12 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714111857.GC1517@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=ian.molton@codethink.co.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.