* Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
@ 2015-07-14 22:50 ` Alexandre Belloni
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-07-14 22:50 UTC (permalink / raw)
To: Dongsheng Wang; +Cc: a.zummo, rtc-linux, linux-kernel
Hi,
This seems ok, one small nitpick:
On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
> diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c
> index 7e48e53..2081155 100644
> --- a/drivers/rtc/rtc-ds3232.c
> +++ b/drivers/rtc/rtc-ds3232.c
> @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
>
> if (device_can_wakeup(dev)) {
> ds3232->suspended = true;
> - irq_set_irq_wake(client->irq, 1);
> + if (irq_set_irq_wake(client->irq, 1)) {
> + dev_info(dev, "Cannot serve as a wakeup source\n");
I would use dev_warn_once or dev_info_once here to avoid spamming the
log each time the machine is suspended.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread* [rtc-linux] RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
2015-07-14 22:50 ` Alexandre Belloni
@ 2015-07-15 2:06 ` Wang Dongsheng
-1 siblings, 0 replies; 10+ messages in thread
From: Wang Dongsheng @ 2015-07-15 2:06 UTC (permalink / raw)
To: Alexandre Belloni
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Thanks Belloni. :)
Regards,
-Dongsheng
> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: Wednesday, July 15, 2015 6:51 AM
> To: Wang Dongsheng-B40534
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> function
>
> Hi,
>
> This seems ok, one small nitpick:
>
> On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > 7e48e53..2081155 100644
> > --- a/drivers/rtc/rtc-ds3232.c
> > +++ b/drivers/rtc/rtc-ds3232.c
> > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> >
> > if (device_can_wakeup(dev)) {
> > ds3232->suspended = true;
> > - irq_set_irq_wake(client->irq, 1);
> > + if (irq_set_irq_wake(client->irq, 1)) {
> > + dev_info(dev, "Cannot serve as a wakeup source\n");
>
> I would use dev_warn_once or dev_info_once here to avoid spamming the log each
> time the machine is suspended.
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
@ 2015-07-15 2:06 ` Wang Dongsheng
0 siblings, 0 replies; 10+ messages in thread
From: Wang Dongsheng @ 2015-07-15 2:06 UTC (permalink / raw)
To: Alexandre Belloni
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Thanks Belloni. :)
Regards,
-Dongsheng
> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: Wednesday, July 15, 2015 6:51 AM
> To: Wang Dongsheng-B40534
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> function
>
> Hi,
>
> This seems ok, one small nitpick:
>
> On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > 7e48e53..2081155 100644
> > --- a/drivers/rtc/rtc-ds3232.c
> > +++ b/drivers/rtc/rtc-ds3232.c
> > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> >
> > if (device_can_wakeup(dev)) {
> > ds3232->suspended = true;
> > - irq_set_irq_wake(client->irq, 1);
> > + if (irq_set_irq_wake(client->irq, 1)) {
> > + dev_info(dev, "Cannot serve as a wakeup source\n");
>
> I would use dev_warn_once or dev_info_once here to avoid spamming the log each
> time the machine is suspended.
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [rtc-linux] RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
2015-07-14 22:50 ` Alexandre Belloni
@ 2015-08-12 7:50 ` Wang Dongsheng
-1 siblings, 0 replies; 10+ messages in thread
From: Wang Dongsheng @ 2015-08-12 7:50 UTC (permalink / raw)
To: Alexandre Belloni
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Hi Belloni,
I am not found this patch in your tree(rtc-fixes and rtc-next), Need I send v2 patch? :)
Regards,
-Dongsheng
> -----Original Message-----
> From: Wang Dongsheng-B40534
> Sent: Wednesday, July 15, 2015 10:06 AM
> To: 'Alexandre Belloni'
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> function
>
> Thanks Belloni. :)
>
> Regards,
> -Dongsheng
>
> > -----Original Message-----
> > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> > Sent: Wednesday, July 15, 2015 6:51 AM
> > To: Wang Dongsheng-B40534
> > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in
> > resume function
> >
> > Hi,
> >
> > This seems ok, one small nitpick:
> >
> > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > > 7e48e53..2081155 100644
> > > --- a/drivers/rtc/rtc-ds3232.c
> > > +++ b/drivers/rtc/rtc-ds3232.c
> > > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> > >
> > > if (device_can_wakeup(dev)) {
> > > ds3232->suspended = true;
> > > - irq_set_irq_wake(client->irq, 1);
> > > + if (irq_set_irq_wake(client->irq, 1)) {
> > > + dev_info(dev, "Cannot serve as a wakeup source\n");
> >
> > I would use dev_warn_once or dev_info_once here to avoid spamming the
> > log each time the machine is suspended.
> >
> > --
> > Alexandre Belloni, Free Electrons
> > Embedded Linux, Kernel and Android engineering
> > http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
@ 2015-08-12 7:50 ` Wang Dongsheng
0 siblings, 0 replies; 10+ messages in thread
From: Wang Dongsheng @ 2015-08-12 7:50 UTC (permalink / raw)
To: Alexandre Belloni
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Hi Belloni,
I am not found this patch in your tree(rtc-fixes and rtc-next), Need I send v2 patch? :)
Regards,
-Dongsheng
> -----Original Message-----
> From: Wang Dongsheng-B40534
> Sent: Wednesday, July 15, 2015 10:06 AM
> To: 'Alexandre Belloni'
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> function
>
> Thanks Belloni. :)
>
> Regards,
> -Dongsheng
>
> > -----Original Message-----
> > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> > Sent: Wednesday, July 15, 2015 6:51 AM
> > To: Wang Dongsheng-B40534
> > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in
> > resume function
> >
> > Hi,
> >
> > This seems ok, one small nitpick:
> >
> > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > > 7e48e53..2081155 100644
> > > --- a/drivers/rtc/rtc-ds3232.c
> > > +++ b/drivers/rtc/rtc-ds3232.c
> > > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> > >
> > > if (device_can_wakeup(dev)) {
> > > ds3232->suspended = true;
> > > - irq_set_irq_wake(client->irq, 1);
> > > + if (irq_set_irq_wake(client->irq, 1)) {
> > > + dev_info(dev, "Cannot serve as a wakeup source\n");
> >
> > I would use dev_warn_once or dev_info_once here to avoid spamming the
> > log each time the machine is suspended.
> >
> > --
> > Alexandre Belloni, Free Electrons
> > Embedded Linux, Kernel and Android engineering
> > http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread* [rtc-linux] Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
2015-08-12 7:50 ` Wang Dongsheng
@ 2015-08-12 8:10 ` Alexandre Belloni
-1 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-08-12 8:10 UTC (permalink / raw)
To: Wang Dongsheng
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Hi,
On 12/08/2015 at 07:50:03 +0000, Wang Dongsheng wrote :
> Hi Belloni,
>
> I am not found this patch in your tree(rtc-fixes and rtc-next), Need I send v2 patch? :)
>
Yes, I was expecting that you would send a new version.
> Regards,
> -Dongsheng
>
> > -----Original Message-----
> > From: Wang Dongsheng-B40534
> > Sent: Wednesday, July 15, 2015 10:06 AM
> > To: 'Alexandre Belloni'
> > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > kernel@vger.kernel.org
> > Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> > function
> >
> > Thanks Belloni. :)
> >
> > Regards,
> > -Dongsheng
> >
> > > -----Original Message-----
> > > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> > > Sent: Wednesday, July 15, 2015 6:51 AM
> > > To: Wang Dongsheng-B40534
> > > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > > kernel@vger.kernel.org
> > > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in
> > > resume function
> > >
> > > Hi,
> > >
> > > This seems ok, one small nitpick:
> > >
> > > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > > > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > > > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > > > 7e48e53..2081155 100644
> > > > --- a/drivers/rtc/rtc-ds3232.c
> > > > +++ b/drivers/rtc/rtc-ds3232.c
> > > > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> > > >
> > > > if (device_can_wakeup(dev)) {
> > > > ds3232->suspended = true;
> > > > - irq_set_irq_wake(client->irq, 1);
> > > > + if (irq_set_irq_wake(client->irq, 1)) {
> > > > + dev_info(dev, "Cannot serve as a wakeup source\n");
> > >
> > > I would use dev_warn_once or dev_info_once here to avoid spamming the
> > > log each time the machine is suspended.
> > >
> > > --
> > > Alexandre Belloni, Free Electrons
> > > Embedded Linux, Kernel and Android engineering
> > > http://free-electrons.com
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume function
@ 2015-08-12 8:10 ` Alexandre Belloni
0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-08-12 8:10 UTC (permalink / raw)
To: Wang Dongsheng
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Hi,
On 12/08/2015 at 07:50:03 +0000, Wang Dongsheng wrote :
> Hi Belloni,
>
> I am not found this patch in your tree(rtc-fixes and rtc-next), Need I send v2 patch? :)
>
Yes, I was expecting that you would send a new version.
> Regards,
> -Dongsheng
>
> > -----Original Message-----
> > From: Wang Dongsheng-B40534
> > Sent: Wednesday, July 15, 2015 10:06 AM
> > To: 'Alexandre Belloni'
> > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > kernel@vger.kernel.org
> > Subject: RE: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in resume
> > function
> >
> > Thanks Belloni. :)
> >
> > Regards,
> > -Dongsheng
> >
> > > -----Original Message-----
> > > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> > > Sent: Wednesday, July 15, 2015 6:51 AM
> > > To: Wang Dongsheng-B40534
> > > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> > > kernel@vger.kernel.org
> > > Subject: Re: [PATCH] rtc/ds3232: fix ds3232 get a WARNING trace in
> > > resume function
> > >
> > > Hi,
> > >
> > > This seems ok, one small nitpick:
> > >
> > > On 07/07/2015 at 14:12:56 +0800, Dongsheng Wang wrote :
> > > > From: Wang Dongsheng <dongsheng.wang@freescale.com> diff --git
> > > > a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index
> > > > 7e48e53..2081155 100644
> > > > --- a/drivers/rtc/rtc-ds3232.c
> > > > +++ b/drivers/rtc/rtc-ds3232.c
> > > > @@ -463,7 +463,10 @@ static int ds3232_suspend(struct device *dev)
> > > >
> > > > if (device_can_wakeup(dev)) {
> > > > ds3232->suspended = true;
> > > > - irq_set_irq_wake(client->irq, 1);
> > > > + if (irq_set_irq_wake(client->irq, 1)) {
> > > > + dev_info(dev, "Cannot serve as a wakeup source\n");
> > >
> > > I would use dev_warn_once or dev_info_once here to avoid spamming the
> > > log each time the machine is suspended.
> > >
> > > --
> > > Alexandre Belloni, Free Electrons
> > > Embedded Linux, Kernel and Android engineering
> > > http://free-electrons.com
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread