All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 4/5] staging: sm7xxfb: define new macros
Date: Wed, 15 Jul 2015 04:58:56 +0000	[thread overview]
Message-ID: <20150715044655.GA17865@sudip-PC> (raw)
In-Reply-To: <20150715030508.GA20352@kroah.com>

On Tue, Jul 14, 2015 at 08:05:08PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote:
> > +#define mmio_addr		0x00c00000
> > +#define seqw17
> 
> Odd, empty macros are not good, because:
> 
> > -#ifdef __BIG_ENDIAN
> >  		if (sfb->fb->var.bits_per_pixel = 32)
> > -			smtc_seqw(0x17, 0x30);
> > -#endif
> > +			seqw17;
> 
> That just looks wrong :(
I think it will look better in c file if I make it as
#define seqw17()
I will respin the patches and send.

regards
sudip 

WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 4/5] staging: sm7xxfb: define new macros
Date: Wed, 15 Jul 2015 10:16:56 +0530	[thread overview]
Message-ID: <20150715044655.GA17865@sudip-PC> (raw)
In-Reply-To: <20150715030508.GA20352@kroah.com>

On Tue, Jul 14, 2015 at 08:05:08PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote:
> > +#define mmio_addr		0x00c00000
> > +#define seqw17
> 
> Odd, empty macros are not good, because:
> 
> > -#ifdef __BIG_ENDIAN
> >  		if (sfb->fb->var.bits_per_pixel == 32)
> > -			smtc_seqw(0x17, 0x30);
> > -#endif
> > +			seqw17;
> 
> That just looks wrong :(
I think it will look better in c file if I make it as
#define seqw17()
I will respin the patches and send.

regards
sudip 

  reply	other threads:[~2015-07-15  4:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  8:14 [PATCH 0/5] staging: sm7xxfb: few changes Sudip Mukherjee
2015-07-07  8:26 ` Sudip Mukherjee
2015-07-07  8:14 ` [PATCH 1/5] staging: sm7xxfb: remove unused macros Sudip Mukherjee
2015-07-07  8:26   ` Sudip Mukherjee
2015-07-07  8:14 ` [PATCH 2/5] staging: sm7xxfb: fix error handling Sudip Mukherjee
2015-07-07  8:26   ` Sudip Mukherjee
2015-07-07  8:14 ` [PATCH 3/5] staging: sm7xxfb: use kernel commandline Sudip Mukherjee
2015-07-07  8:26   ` Sudip Mukherjee
2015-07-15  3:06   ` Greg Kroah-Hartman
2015-07-15  3:06     ` Greg Kroah-Hartman
2015-07-07  8:14 ` [PATCH 4/5] staging: sm7xxfb: define new macros Sudip Mukherjee
2015-07-07  8:26   ` Sudip Mukherjee
2015-07-15  3:05   ` Greg Kroah-Hartman
2015-07-15  3:05     ` Greg Kroah-Hartman
2015-07-15  4:46     ` Sudip Mukherjee [this message]
2015-07-15  4:58       ` Sudip Mukherjee
2015-07-07  8:14 ` [PATCH 5/5] staging: sm7xxfb: usr fb_read and fb_write Sudip Mukherjee
2015-07-07  8:26   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150715044655.GA17865@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.