All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Robert Richter <rrichter@cavium.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 0/5] arm64, pci: Add ECAM/PCIe support for Cavium ThunderX
Date: Wed, 15 Jul 2015 18:07:01 +0100	[thread overview]
Message-ID: <20150715170701.GA19480@leverpostej> (raw)
In-Reply-To: <1436979285-8177-1-git-send-email-ddaney.cavm@gmail.com>

Hi,

On Wed, Jul 15, 2015 at 05:54:40PM +0100, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
> 
> The subject pretty much says it all.  The first four patches tweak the
> infrastructure a little so that we can get required behavior.  The
> final patch adds the drivers.
> 
> David Daney (5):
>   pci: Add is_pcierc element to struct pci_bus
>   gic-its: Allow pci_requester_id to be overridden.
>   arm64, pci: Allow RC drivers to supply pcibios_add_device()
>     implementation.
>   irqchip: gic-v3: Add gic_get_irq_domain() to get the irqdomain of the
>     GIC.
>   PCI: Add host drivers for Cavium ThunderX processors.
> 
>  arch/arm64/include/asm/pci.h        |   3 +
>  arch/arm64/kernel/pci.c             |  10 +
>  drivers/irqchip/irq-gic-v3-its.c    |  14 +-
>  drivers/irqchip/irq-gic-v3.c        |   5 +
>  drivers/pci/host/Kconfig            |  12 +
>  drivers/pci/host/Makefile           |   2 +
>  drivers/pci/host/pcie-thunder-pem.c | 462 ++++++++++++++++++++++++++++++++++++
>  drivers/pci/host/pcie-thunder.c     | 422 ++++++++++++++++++++++++++++++++
>  drivers/pci/probe.c                 |   2 +
>  include/linux/irqchip/arm-gic-v3.h  |   3 +
>  include/linux/pci.h                 |   1 +
>  11 files changed, 935 insertions(+), 1 deletion(-)

I note that the driver attempts to probe with DT, yet there is no DT
binding in this patch, nor has the devicetree mailing list been placed
on Cc.

A DT binding document is mandatory for anything probing via DT.

Please write one, and submit it (as its own patch) with the next version
of this series as per
Documentation/devicetree/bindings/submitting-patches.txt.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] arm64, pci: Add ECAM/PCIe support for Cavium ThunderX
Date: Wed, 15 Jul 2015 18:07:01 +0100	[thread overview]
Message-ID: <20150715170701.GA19480@leverpostej> (raw)
In-Reply-To: <1436979285-8177-1-git-send-email-ddaney.cavm@gmail.com>

Hi,

On Wed, Jul 15, 2015 at 05:54:40PM +0100, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
> 
> The subject pretty much says it all.  The first four patches tweak the
> infrastructure a little so that we can get required behavior.  The
> final patch adds the drivers.
> 
> David Daney (5):
>   pci: Add is_pcierc element to struct pci_bus
>   gic-its: Allow pci_requester_id to be overridden.
>   arm64, pci: Allow RC drivers to supply pcibios_add_device()
>     implementation.
>   irqchip: gic-v3: Add gic_get_irq_domain() to get the irqdomain of the
>     GIC.
>   PCI: Add host drivers for Cavium ThunderX processors.
> 
>  arch/arm64/include/asm/pci.h        |   3 +
>  arch/arm64/kernel/pci.c             |  10 +
>  drivers/irqchip/irq-gic-v3-its.c    |  14 +-
>  drivers/irqchip/irq-gic-v3.c        |   5 +
>  drivers/pci/host/Kconfig            |  12 +
>  drivers/pci/host/Makefile           |   2 +
>  drivers/pci/host/pcie-thunder-pem.c | 462 ++++++++++++++++++++++++++++++++++++
>  drivers/pci/host/pcie-thunder.c     | 422 ++++++++++++++++++++++++++++++++
>  drivers/pci/probe.c                 |   2 +
>  include/linux/irqchip/arm-gic-v3.h  |   3 +
>  include/linux/pci.h                 |   1 +
>  11 files changed, 935 insertions(+), 1 deletion(-)

I note that the driver attempts to probe with DT, yet there is no DT
binding in this patch, nor has the devicetree mailing list been placed
on Cc.

A DT binding document is mandatory for anything probing via DT.

Please write one, and submit it (as its own patch) with the next version
of this series as per
Documentation/devicetree/bindings/submitting-patches.txt.

Thanks,
Mark.

  parent reply	other threads:[~2015-07-15 17:07 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 16:54 [PATCH 0/5] arm64, pci: Add ECAM/PCIe support for Cavium ThunderX David Daney
2015-07-15 16:54 ` David Daney
2015-07-15 16:54 ` [PATCH 1/5] pci: Add is_pcierc element to struct pci_bus David Daney
2015-07-15 16:54   ` David Daney
2015-07-15 16:54 ` [PATCH 2/5] gic-its: Allow pci_requester_id to be overridden David Daney
2015-07-15 16:54   ` David Daney
2015-07-15 17:30   ` Marc Zyngier
2015-07-15 17:30     ` Marc Zyngier
2015-08-20 14:11   ` Pavel Fedin
2015-08-20 14:11     ` Pavel Fedin
2015-08-20 15:23     ` David Daney
2015-08-20 15:23       ` David Daney
2015-08-25 11:01       ` Pavel Fedin
2015-08-25 11:01         ` Pavel Fedin
2015-07-15 16:54 ` [PATCH 3/5] arm64, pci: Allow RC drivers to supply pcibios_add_device() implementation David Daney
2015-07-15 16:54   ` David Daney
2015-07-16  9:04   ` Lorenzo Pieralisi
2015-07-16  9:04     ` Lorenzo Pieralisi
2015-07-16 17:00     ` David Daney
2015-07-16 17:00       ` David Daney
2015-07-17 11:00       ` Lorenzo Pieralisi
2015-07-17 11:00         ` Lorenzo Pieralisi
2015-07-17 16:38         ` David Daney
2015-07-17 16:38           ` David Daney
2015-07-17 17:15           ` Mark Rutland
2015-07-17 17:15             ` Mark Rutland
2015-07-15 16:54 ` [PATCH 4/5] irqchip: gic-v3: Add gic_get_irq_domain() to get the irqdomain of the GIC David Daney
2015-07-15 16:54   ` David Daney
2015-07-15 17:12   ` Marc Zyngier
2015-07-15 17:12     ` Marc Zyngier
2015-07-15 18:57     ` David Daney
2015-07-15 18:57       ` David Daney
2015-07-16  7:38       ` Marc Zyngier
2015-07-16  7:38         ` Marc Zyngier
2015-07-16 16:50         ` David Daney
2015-07-16 16:50           ` David Daney
2015-07-16 17:09           ` Marc Zyngier
2015-07-16 17:09             ` Marc Zyngier
2015-07-16 17:14             ` David Daney
2015-07-16 17:14               ` David Daney
2015-07-16 17:32               ` Marc Zyngier
2015-07-16 17:32                 ` Marc Zyngier
2015-07-17  6:45                 ` Marc Zyngier
2015-07-17  6:45                   ` Marc Zyngier
2015-07-15 16:54 ` [PATCH 5/5] PCI: Add host drivers for Cavium ThunderX processors David Daney
2015-07-15 16:54   ` David Daney
2015-07-15 17:44   ` Mark Rutland
2015-07-15 17:44     ` Mark Rutland
2015-07-15 17:48   ` Marc Zyngier
2015-07-15 17:48     ` Marc Zyngier
2015-07-16  8:31   ` Paul Bolle
2015-07-16  8:31     ` Paul Bolle
2015-07-16 16:52     ` David Daney
2015-07-16 16:52       ` David Daney
2015-07-16 13:06   ` Lorenzo Pieralisi
2015-07-16 13:06     ` Lorenzo Pieralisi
2015-07-17 12:12   ` Arnd Bergmann
2015-07-17 12:12     ` Arnd Bergmann
2015-07-15 17:07 ` Mark Rutland [this message]
2015-07-15 17:07   ` [PATCH 0/5] arm64, pci: Add ECAM/PCIe support for Cavium ThunderX Mark Rutland
2015-07-15 17:29   ` Will Deacon
2015-07-15 17:29     ` Will Deacon
2015-07-16 17:25 ` Thomas Gleixner
2015-07-16 17:25   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150715170701.GA19480@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=bhelgaas@google.com \
    --cc=david.daney@cavium.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rrichter@cavium.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.