From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Dean Nelson <dnelson@redhat.com>, Tony Luck <tony.luck@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Hugh Dickins <hughd@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp
Date: Thu, 16 Jul 2015 04:33:07 +0200 [thread overview]
Message-ID: <20150716023307.GF1747@two.firstfloor.org> (raw)
In-Reply-To: <1437010894-10262-4-git-send-email-n-horiguchi@ah.jp.nec.com>
> @@ -909,6 +909,15 @@ int get_hwpoison_page(struct page *page)
> * directly for tail pages.
> */
> if (PageTransHuge(head)) {
> + /*
> + * Non anonymous thp exists only in allocation/free time. We
> + * can't handle such a case correctly, so let's give it up.
> + * This should be better than triggering BUG_ON when kernel
> + * tries to touch a "partially handled" page.
> + */
> + if (!PageAnon(head))
> + return 0;
Please print a message for this case. In the future there will be
likely more non anonymous THP pages from Kirill's large page cache work
(so eventually we'll need it)
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Dean Nelson <dnelson@redhat.com>, Tony Luck <tony.luck@intel.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Hugh Dickins <hughd@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp
Date: Thu, 16 Jul 2015 04:33:07 +0200 [thread overview]
Message-ID: <20150716023307.GF1747@two.firstfloor.org> (raw)
In-Reply-To: <1437010894-10262-4-git-send-email-n-horiguchi@ah.jp.nec.com>
> @@ -909,6 +909,15 @@ int get_hwpoison_page(struct page *page)
> * directly for tail pages.
> */
> if (PageTransHuge(head)) {
> + /*
> + * Non anonymous thp exists only in allocation/free time. We
> + * can't handle such a case correctly, so let's give it up.
> + * This should be better than triggering BUG_ON when kernel
> + * tries to touch a "partially handled" page.
> + */
> + if (!PageAnon(head))
> + return 0;
Please print a message for this case. In the future there will be
likely more non anonymous THP pages from Kirill's large page cache work
(so eventually we'll need it)
-Andi
next prev parent reply other threads:[~2015-07-16 2:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 1:41 [PATCH v1 0/4] hwpoison: fixes on v4.2-rc2 Naoya Horiguchi
2015-07-16 1:41 ` Naoya Horiguchi
2015-07-16 1:41 ` [PATCH v1 2/4] mm/memory-failure: fix race in counting num_poisoned_pages Naoya Horiguchi
2015-07-16 1:41 ` Naoya Horiguchi
2015-07-16 1:41 ` [PATCH v1 1/4] mm/memory-failure: unlock_page before put_page Naoya Horiguchi
2015-07-16 1:41 ` Naoya Horiguchi
2015-07-16 1:41 ` [PATCH v1 4/4] mm/memory-failure: check __PG_HWPOISON separately from PAGE_FLAGS_CHECK_AT_* Naoya Horiguchi
2015-07-16 1:41 ` Naoya Horiguchi
2015-07-23 20:37 ` Andrew Morton
2015-07-23 20:37 ` Andrew Morton
2015-07-23 23:13 ` Naoya Horiguchi
2015-07-23 23:13 ` Naoya Horiguchi
2015-07-16 1:41 ` [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp Naoya Horiguchi
2015-07-16 1:41 ` Naoya Horiguchi
2015-07-16 2:33 ` Andi Kleen [this message]
2015-07-16 2:33 ` Andi Kleen
2015-07-16 2:41 ` Naoya Horiguchi
2015-07-16 2:41 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716023307.GF1747@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dnelson@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nao.horiguchi@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.