From: Paul Mackerras <paulus@samba.org>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*
Date: Thu, 16 Jul 2015 22:12:59 +1000 [thread overview]
Message-ID: <20150716121259.GA18219@iris.ozlabs.ibm.com> (raw)
The hardware RNG on POWER8 and POWER7+ can be relatively slow, since
it can only supply one 64-bit value per microsecond. Currently we
read it in arch_get_random_long(), but that slows down reading from
/dev/urandom since the code in random.c calls arch_get_random_long()
for every longword read from /dev/urandom.
Since the hardware RNG supplies high-quality entropy on every read, it
matches the semantics of arch_get_random_seed_long() better than those
of arch_get_random_long(). Therefore this commit makes the code use
the hardware RNG only for arch_get_random_seed_{long,int} and not for
arch_get_random_{long,int}.
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
arch/powerpc/include/asm/archrandom.h | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/powerpc/include/asm/archrandom.h b/arch/powerpc/include/asm/archrandom.h
index 0cc6eed..a4c3f54 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -7,13 +7,22 @@
static inline int arch_get_random_long(unsigned long *v)
{
+ return 0;
+}
+
+static inline int arch_get_random_int(unsigned int *v)
+{
+ return 0;
+}
+
+static inline int arch_get_random_seed_long(unsigned long *v)
+{
if (ppc_md.get_random_long)
return ppc_md.get_random_long(v);
return 0;
}
-
-static inline int arch_get_random_int(unsigned int *v)
+static inline int arch_get_random_seed_int(unsigned int *v)
{
unsigned long val;
int rc;
@@ -27,22 +36,13 @@ static inline int arch_get_random_int(unsigned int *v)
static inline int arch_has_random(void)
{
- return !!ppc_md.get_random_long;
-}
-
-static inline int arch_get_random_seed_long(unsigned long *v)
-{
- return 0;
-}
-static inline int arch_get_random_seed_int(unsigned int *v)
-{
return 0;
}
+
static inline int arch_has_random_seed(void)
{
- return 0;
+ return !!ppc_md.get_random_long;
}
-
#endif /* CONFIG_ARCH_RANDOM */
#ifdef CONFIG_PPC_POWERNV
--
2.1.4
next reply other threads:[~2015-07-16 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:12 Paul Mackerras [this message]
2015-07-17 4:44 ` [PATCH] powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_* Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2015-07-17 9:15 Paul Mackerras
2015-07-17 9:37 ` Segher Boessenkool
2015-07-17 10:09 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716121259.GA18219@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.