From: Segher Boessenkool <segher@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, tytso@mit.edu,
herbert@gondor.apana.org.au, mpm@selenic.com,
hpa@linux.intel.com, keescook@chromium.org
Subject: Re: [PATCH] powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*
Date: Fri, 17 Jul 2015 04:37:57 -0500 [thread overview]
Message-ID: <20150717093757.GA15502@gate.crashing.org> (raw)
In-Reply-To: <20150717091558.GA5916@iris.ozlabs.ibm.com>
On Fri, Jul 17, 2015 at 07:15:58PM +1000, Paul Mackerras wrote:
> @@ -7,13 +7,22 @@
>
> static inline int arch_get_random_long(unsigned long *v)
> {
> + return 0;
> +}
> +
> +static inline int arch_get_random_int(unsigned int *v)
> +{
> + return 0;
> +}
> +
> +static inline int arch_get_random_seed_long(unsigned long *v)
> +{
> if (ppc_md.get_random_long)
> return ppc_md.get_random_long(v);
You probably want to change that last name (ppc_md.get_random_long) then?
Pretty confusing like this :-)
Segher
next prev parent reply other threads:[~2015-07-17 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 9:15 [PATCH] powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_* Paul Mackerras
2015-07-17 9:37 ` Segher Boessenkool [this message]
2015-07-17 10:09 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2015-07-16 12:12 Paul Mackerras
2015-07-17 4:44 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717093757.GA15502@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpm@selenic.com \
--cc=paulus@samba.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.