Re: [Qemu-devel] memory hotplug fails with mem-merge option

[Bharata B Rao <bharata@linux.vnet.ibm.com>]

On Fri, Jul 17, 2015 at 10:26:16AM +0300, Marcel Apfelbaum wrote:
> On 07/16/2015 03:24 PM, Igor Mammedov wrote:
> >On Thu, 16 Jul 2015 16:00:07 +0530
> >Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
> >
> >>On Thu, Jul 16, 2015 at 10:25:09AM +0530, Bharata B Rao wrote:
> >>>Hi,
> >>>
> >>>When I use -machine pc,mem-merge=off|on -m 1G,slots=4,maxmem=2G, adding
> >>>memory-backend-ram object fails like below. Same failure is seen with
> >>>-machine pseries,mem-merge=on|off.
> >>>
> >>>(qemu) object_add memory-backend-ram,id=ram0,size=1G
> >>>
> >>>qemu-system-x86_64: util/qemu-option.c:388: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed.
> >>
> >>Same failure seen with -machine pseries,mem-merge=off when used together with
> >>-object memory-backend-file on QEMU commandline in which case boot time
> >>failure is observed.
> >>
> >>Regards,
> >>Bharata.
> >
> >looks like related to
> >
> >0a7cf217 util/qemu-config: fix regression of qmp_query_command_line_options
> >and
> >49d2e64 machine: remove qemu_machine_opts global list
> >
> >CCing Marcel in hope he knows how to fix it right away.
> Hi,
> 
> Can you please check that Eduardo's patch fixes this?
>     [PATCH] hostmem: Fix qemu_opt_get_bool() crash in host_memory_backend_init()
>     https://www.mail-archive.com/qemu-devel@nongnu.org/msg310915.html

Yes, this fixes the problem.

Regards,
Bharata.