From: Christoffer Dall <christoffer.dall@linaro.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: kvm@vger.kernel.org, Andre Przywara <andre.przywara@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/10] arm/arm64: KVM: Move vgic handling to a non-preemptible section
Date: Sat, 18 Jul 2015 00:15:27 +0200 [thread overview]
Message-ID: <20150717221527.GI14024@cbox> (raw)
In-Reply-To: <1436378202-20224-3-git-send-email-marc.zyngier@arm.com>
On Wed, Jul 08, 2015 at 06:56:34PM +0100, Marc Zyngier wrote:
> As we're about to introduce some serious GIC-poking to the vgic code,
> it is important to make sure that we're going to poke the part of
> the GIC that belongs to the CPU we're about to run on (otherwise,
> we'd end up with some unexpected interrupts firing)...
>
> Introducing a non-preemptible section in kvm_arch_vcpu_ioctl_run
> prevents the problem from occuring.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 02/10] arm/arm64: KVM: Move vgic handling to a non-preemptible section
Date: Sat, 18 Jul 2015 00:15:27 +0200 [thread overview]
Message-ID: <20150717221527.GI14024@cbox> (raw)
In-Reply-To: <1436378202-20224-3-git-send-email-marc.zyngier@arm.com>
On Wed, Jul 08, 2015 at 06:56:34PM +0100, Marc Zyngier wrote:
> As we're about to introduce some serious GIC-poking to the vgic code,
> it is important to make sure that we're going to poke the part of
> the GIC that belongs to the CPU we're about to run on (otherwise,
> we'd end up with some unexpected interrupts firing)...
>
> Introducing a non-preemptible section in kvm_arch_vcpu_ioctl_run
> prevents the problem from occuring.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> Reviewed-by: Alex Benn?e <alex.bennee@linaro.org>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2015-07-17 22:03 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 17:56 [PATCH v2 00/10] arm/arm64: KVM: Active interrupt state switching for shared devices Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 01/10] arm/arm64: KVM: Fix ordering of timer/GIC on guest entry Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 02/10] arm/arm64: KVM: Move vgic handling to a non-preemptible section Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall [this message]
2015-07-17 22:15 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 03/10] KVM: arm/arm64: vgic: Convert struct vgic_lr to use bitfields Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-17 22:15 ` Christoffer Dall
2015-07-21 18:02 ` Marc Zyngier
2015-07-21 18:02 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 04/10] KVM: arm/arm64: vgic: Allow HW irq to be encoded in LR Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 19:50 ` Christoffer Dall
2015-07-17 19:50 ` Christoffer Dall
2015-07-21 16:38 ` Marc Zyngier
2015-07-21 16:38 ` Marc Zyngier
2015-08-04 12:14 ` Christoffer Dall
2015-08-04 12:14 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-17 22:15 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 06/10] KVM: arm/arm64: vgic: Allow dynamic mapping of physical/virtual interrupts Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 21:11 ` Christoffer Dall
2015-07-17 21:11 ` Christoffer Dall
2015-07-21 17:17 ` Marc Zyngier
2015-07-21 17:17 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 07/10] KVM: arm/arm64: vgic: Allow HW interrupts to be queued to a guest Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 21:56 ` Christoffer Dall
2015-07-17 21:56 ` Christoffer Dall
2015-07-21 17:21 ` Marc Zyngier
2015-07-21 17:21 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 08/10] KVM: arm/arm64: vgic: Add vgic_{get,set}_phys_irq_active Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 08/10] KVM: arm/arm64: vgic: Add vgic_{get, set}_phys_irq_active Marc Zyngier
2015-07-17 22:15 ` [PATCH v2 08/10] KVM: arm/arm64: vgic: Add vgic_{get,set}_phys_irq_active Christoffer Dall
2015-07-17 22:15 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 09/10] KVM: arm/arm64: timer: Allow the timer to control the active state Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-17 22:15 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 10/10] KVM: arm/arm64: vgic: Allow non-shared device HW interrupts Marc Zyngier
2015-07-08 17:56 ` Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-17 22:15 ` Christoffer Dall
2015-07-21 18:01 ` Marc Zyngier
2015-07-21 18:01 ` Marc Zyngier
2015-08-04 12:26 ` Christoffer Dall
2015-08-04 12:26 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717221527.GI14024@cbox \
--to=christoffer.dall@linaro.org \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.