Re: [PATCH v2] zsmalloc: do not take class lock in zs_shrinker_count()

[Sergey Senozhatsky <sergey.senozhatsky@gmail.com>]

Hi,

On (07/18/15 07:42), Minchan Kim wrote:
> I asked to remove the comment of zs_can_compact about lock.
> "Should be called under class->lock."

Oh... I somehow quickly read it and thought you were talking
about the commit message. Fixed and resent.

> Otherwise,
> 
> Acked-by: Minchan Kim <minchan@kernel.org>

Thanks.

	-ss

> > ---
> >  mm/zsmalloc.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 1edd8a0..ed64cf5 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -1836,9 +1836,7 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker,
> >  		if (class->index != i)
> >  			continue;
> >  
> > -		spin_lock(&class->lock);
> >  		pages_to_free += zs_can_compact(class);
> > -		spin_unlock(&class->lock);
> >  	}
> >  
> >  	return pages_to_free;
> > -- 
> > 2.4.6
> > 
> 
> -- 
> Kind regards,
> Minchan Kim
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>