From: Brian Norris <computersforpeace@gmail.com>
To: Roy Spliet <r.spliet@ultimaker.com>
Cc: Linux MTD <linux-mtd@lists.infradead.org>,
Linux ARM kernel <linux-arm-kernel@lists.infradead.org>,
Linux sunxi <linux-sunxi@googlegroups.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v5 1/2] mtd: nand: sunxi: Replace failsafe timing cfg with calculated value
Date: Mon, 20 Jul 2015 10:46:18 -0700 [thread overview]
Message-ID: <20150720174618.GF24125@google.com> (raw)
In-Reply-To: <1435309211-15236-1-git-send-email-r.spliet@ultimaker.com>
On Fri, Jun 26, 2015 at 11:00:10AM +0200, Roy Spliet wrote:
> The TIMING_CFG register was previously statically set to a magic value
> (extracted from Allwinner's BSP) when initializing the NAND controller.
> Now that we have more details about the TIMING_CFG register layout
> (extracted from the A83 user manual) we can dynamically calculate the
> appropriate value for each NAND chip and set it when selecting the
> chip.
>
> Signed-off-by: Roy Spliet <r.spliet@ultimaker.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> ---
> V2:
> - Fix crippled comments
>
> V3:
> - Warn for invalid timings
> - Style
>
> V4:
> - Make better use of return types
> - Style and comments
> - Remove superfluous initialisation
>
> V5:
> - Tidy up macros
Pushed both to l2-mtd.git. Thanks!
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] mtd: nand: sunxi: Replace failsafe timing cfg with calculated value
Date: Mon, 20 Jul 2015 10:46:18 -0700 [thread overview]
Message-ID: <20150720174618.GF24125@google.com> (raw)
In-Reply-To: <1435309211-15236-1-git-send-email-r.spliet@ultimaker.com>
On Fri, Jun 26, 2015 at 11:00:10AM +0200, Roy Spliet wrote:
> The TIMING_CFG register was previously statically set to a magic value
> (extracted from Allwinner's BSP) when initializing the NAND controller.
> Now that we have more details about the TIMING_CFG register layout
> (extracted from the A83 user manual) we can dynamically calculate the
> appropriate value for each NAND chip and set it when selecting the
> chip.
>
> Signed-off-by: Roy Spliet <r.spliet@ultimaker.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> ---
> V2:
> - Fix crippled comments
>
> V3:
> - Warn for invalid timings
> - Style
>
> V4:
> - Make better use of return types
> - Style and comments
> - Remove superfluous initialisation
>
> V5:
> - Tidy up macros
Pushed both to l2-mtd.git. Thanks!
Brian
next prev parent reply other threads:[~2015-07-20 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:00 [PATCH v5 1/2] mtd: nand: sunxi: Replace failsafe timing cfg with calculated value Roy Spliet
2015-06-26 9:00 ` Roy Spliet
2015-06-26 9:00 ` [PATCH v5 2/2] mtd: nand: sunxi: Set serial access mode correctly Roy Spliet
2015-06-26 9:00 ` Roy Spliet
2015-07-20 17:46 ` Brian Norris [this message]
2015-07-20 17:46 ` [PATCH v5 1/2] mtd: nand: sunxi: Replace failsafe timing cfg with calculated value Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720174618.GF24125@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=r.spliet@ultimaker.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.