From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL
Date: Mon, 20 Jul 2015 18:53:26 +0000 [thread overview]
Message-ID: <20150720185326.GA2456@localhost.localdomain> (raw)
In-Reply-To: <20150716140314.GC1855@localhost.localdomain>
On Thu, Jul 16, 2015 at 11:03:14AM -0300, Marcelo Ricardo Leitner wrote:
> On Thu, Jul 16, 2015 at 09:50:16AM -0400, Vlad Yasevich wrote:
...
> > I am not familiar enough with DLM and its history, but my question is this:
> > If dlm always peels off a socket for a new associations, why is it using
> > 1-to-many api in the first place? Doing a quick scan of DLM lowcoms code
> > for sctp specific things, I see nothing that has specific dependencies
> > on 1-to-many api. It might be simpler to switch to using 1-to-1 api, similar
> > to dlm tcp and eliminate this dependency.
> >
> > Is that a naive point of view?
>
> Not at all, that's a very good question. I also don't know much of DLM
> code itself, I'll check that.
Sounds like DLM is using 1-to-many just in an attempt to use
multi-homing, but we can do that with 1-to-1 too. I'll draft a patch and
see how it goes, and perhaps with that we can avoid/postpone this
question regarding indirect call to sctp_do_peeloff by kernel.
Marcelo
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL
Date: Mon, 20 Jul 2015 15:53:26 -0300 [thread overview]
Message-ID: <20150720185326.GA2456@localhost.localdomain> (raw)
In-Reply-To: <20150716140314.GC1855@localhost.localdomain>
On Thu, Jul 16, 2015 at 11:03:14AM -0300, Marcelo Ricardo Leitner wrote:
> On Thu, Jul 16, 2015 at 09:50:16AM -0400, Vlad Yasevich wrote:
...
> > I am not familiar enough with DLM and its history, but my question is this:
> > If dlm always peels off a socket for a new associations, why is it using
> > 1-to-many api in the first place? Doing a quick scan of DLM lowcoms code
> > for sctp specific things, I see nothing that has specific dependencies
> > on 1-to-many api. It might be simpler to switch to using 1-to-1 api, similar
> > to dlm tcp and eliminate this dependency.
> >
> > Is that a naive point of view?
>
> Not at all, that's a very good question. I also don't know much of DLM
> code itself, I'll check that.
Sounds like DLM is using 1-to-many just in an attempt to use
multi-homing, but we can do that with 1-to-1 too. I'll draft a patch and
see how it goes, and perhaps with that we can avoid/postpone this
question regarding indirect call to sctp_do_peeloff by kernel.
Marcelo
next prev parent reply other threads:[~2015-07-20 18:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 17:13 [PATCH v2 0/2] Avoid link dependency of dlm on sctp module Marcelo Ricardo Leitner
2015-07-14 17:13 ` Marcelo Ricardo Leitner
2015-07-14 17:13 ` [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL Marcelo Ricardo Leitner
2015-07-14 17:13 ` Marcelo Ricardo Leitner
2015-07-15 13:18 ` Neil Horman
2015-07-15 13:18 ` Neil Horman
2015-07-15 13:24 ` Marcelo Ricardo Leitner
2015-07-15 13:24 ` Marcelo Ricardo Leitner
2015-07-15 20:58 ` David Miller
2015-07-15 20:58 ` David Miller
2015-07-16 13:50 ` Vlad Yasevich
2015-07-16 13:50 ` Vlad Yasevich
2015-07-16 14:03 ` Marcelo Ricardo Leitner
2015-07-16 14:03 ` Marcelo Ricardo Leitner
2015-07-20 18:53 ` Marcelo Ricardo Leitner [this message]
2015-07-20 18:53 ` Marcelo Ricardo Leitner
2015-07-22 13:13 ` David Laight
2015-07-22 13:50 ` Marcelo
2015-07-22 13:50 ` Marcelo
2015-07-14 17:13 ` [PATCH v2 2/2] dlm: avoid using sctp_do_peeloff directly Marcelo Ricardo Leitner
2015-07-14 17:13 ` Marcelo Ricardo Leitner
2015-07-15 13:57 ` [PATCH v2 0/2] Avoid link dependency of dlm on sctp module Neil Horman
2015-07-15 13:57 ` Neil Horman
2015-07-15 20:59 ` David Miller
2015-07-15 20:59 ` David Miller
2015-07-16 11:18 ` Neil Horman
2015-07-16 11:18 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720185326.GA2456@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.