From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] usb: gadget: at91_udc: add support for at91_udc
Date: Tue, 21 Jul 2015 08:59:32 +0200 [thread overview]
Message-ID: <20150721085932.698de418@amdc2363> (raw)
In-Reply-To: <1434372182-8967-3-git-send-email-hs@denx.de>
Hi Heiko,
> ported from linux:
>
> b2ba27a5c56ff: usb: gadget: at91_udc: move prepare clk into process
> context
>
IMHO, presented above description is not enough. I'd prefer to see one
patch which adds the code from linux - including the exact commit
message.
Then, u-boot specific adjustments should be applied in a separate patch.
In that way you would:
1. Avoid #ifdef __UBOOT__
2. Make the process of updating code easier
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> checkpatch detects a lot of errors, but as this code is copied
> from linux, I tend to not fix them, so later updates with
> linux code is easier.
>
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/at91_udc.c | 2203
> +++++++++++++++++++++++++++++++++++++++++
> drivers/usb/gadget/at91_udc.h | 171 ++++
> include/linux/usb/at91_udc.h | 20 + 4 files changed, 2395
> insertions(+) create mode 100644 drivers/usb/gadget/at91_udc.c
> create mode 100644 drivers/usb/gadget/at91_udc.h
> create mode 100644 include/linux/usb/at91_udc.h
>
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index 70bb550..22323fa 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_USB_ETHER) += epautoconf.o config.o
> usbstring.o
> # new USB gadget layer dependencies
> ifdef CONFIG_USB_GADGET
> +obj-$(CONFIG_USB_GADGET_AT91) += at91_udc.o
> obj-$(CONFIG_USB_GADGET_ATMEL_USBA) += atmel_usba_udc.o
> obj-$(CONFIG_USB_GADGET_S3C_UDC_OTG) += s3c_udc_otg.o
> obj-$(CONFIG_USB_GADGET_S3C_UDC_OTG_PHY) += s3c_udc_otg_phy.o
> diff --git a/drivers/usb/gadget/at91_udc.c
> b/drivers/usb/gadget/at91_udc.c new file mode 100644
> index 0000000..f4ae13b
> --- /dev/null
> +++ b/drivers/usb/gadget/at91_udc.c
> @@
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-07-21 6:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:42 [U-Boot] [PATCH 0/3] add dfu support for at91 sam9260 based boards Heiko Schocher
2015-06-15 12:42 ` [U-Boot] [PATCH 1/3] ARM: at91: add cpu.h Heiko Schocher
2015-07-21 1:59 ` Marek Vasut
2015-07-22 14:40 ` Alexandre Belloni
2015-06-15 12:43 ` [U-Boot] [PATCH 2/3] usb: gadget: at91_udc: add support for at91_udc Heiko Schocher
2015-07-21 6:59 ` Lukasz Majewski [this message]
2015-08-10 5:16 ` Heiko Schocher
2015-06-15 12:43 ` [U-Boot] [PATCH 3/3] at91, taurus, smartweb: add dfu support Heiko Schocher
2015-07-21 2:02 ` Marek Vasut
2015-07-21 7:02 ` Lukasz Majewski
2015-07-20 14:03 ` [U-Boot] [PATCH 0/3] add dfu support for at91 sam9260 based boards Lukasz Majewski
2015-07-20 15:20 ` Heiko Schocher
2015-07-21 5:36 ` Lukasz Majewski
2015-07-21 2:03 ` Marek Vasut
2015-08-10 5:14 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721085932.698de418@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.