All of lore.kernel.org
 help / color / mirror / Atom feed
From: bhelgaas@google.com (Bjorn Helgaas)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 3/4] pci: mm: Add pci_pool_zalloc() call
Date: Tue, 21 Jul 2015 14:38:18 -0500	[thread overview]
Message-ID: <20150721193818.GG21967@google.com> (raw)
In-Reply-To: <1436994883-16563-4-git-send-email-sean.stalley@intel.com>

On Wed, Jul 15, 2015 at 02:14:42PM -0700, Sean O. Stalley wrote:
> Add a wrapper function for pci_pool_alloc() to get zeroed memory.
> 
> Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>

If you get details of managing __GFP_ZERO worked out, I'm fine with this
PCI part of it, and you can merge it along with the rest of the series:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Please capitalize "PCI" in the subject line, like this:

  PCI: mm: Add pci_pool_zalloc() call

> ---
>  include/linux/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 755a2cd..e6ec7d9 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1176,6 +1176,8 @@ int pci_set_vga_state(struct pci_dev *pdev, bool decode,
>  		dma_pool_create(name, &pdev->dev, size, align, allocation)
>  #define	pci_pool_destroy(pool) dma_pool_destroy(pool)
>  #define	pci_pool_alloc(pool, flags, handle) dma_pool_alloc(pool, flags, handle)
> +#define	pci_pool_zalloc(pool, flags, handle) \
> +		dma_pool_zalloc(pool, flags, handle)
>  #define	pci_pool_free(pool, vaddr, addr) dma_pool_free(pool, vaddr, addr)
>  
>  enum pci_dma_burst_strategy {
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: "Sean O. Stalley" <sean.stalley@intel.com>
Cc: corbet@lwn.net, vinod.koul@intel.com, Julia.Lawall@lip6.fr,
	Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, mmarek@suse.cz,
	akpm@linux-foundation.org, bigeasy@linutronix.de,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-mm@kvack.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH 3/4] pci: mm: Add pci_pool_zalloc() call
Date: Tue, 21 Jul 2015 14:38:18 -0500	[thread overview]
Message-ID: <20150721193818.GG21967@google.com> (raw)
In-Reply-To: <1436994883-16563-4-git-send-email-sean.stalley@intel.com>

On Wed, Jul 15, 2015 at 02:14:42PM -0700, Sean O. Stalley wrote:
> Add a wrapper function for pci_pool_alloc() to get zeroed memory.
> 
> Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>

If you get details of managing __GFP_ZERO worked out, I'm fine with this
PCI part of it, and you can merge it along with the rest of the series:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Please capitalize "PCI" in the subject line, like this:

  PCI: mm: Add pci_pool_zalloc() call

> ---
>  include/linux/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 755a2cd..e6ec7d9 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1176,6 +1176,8 @@ int pci_set_vga_state(struct pci_dev *pdev, bool decode,
>  		dma_pool_create(name, &pdev->dev, size, align, allocation)
>  #define	pci_pool_destroy(pool) dma_pool_destroy(pool)
>  #define	pci_pool_alloc(pool, flags, handle) dma_pool_alloc(pool, flags, handle)
> +#define	pci_pool_zalloc(pool, flags, handle) \
> +		dma_pool_zalloc(pool, flags, handle)
>  #define	pci_pool_free(pool, vaddr, addr) dma_pool_free(pool, vaddr, addr)
>  
>  enum pci_dma_burst_strategy {
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <bhelgaas@google.com>
To: "Sean O. Stalley" <sean.stalley@intel.com>
Cc: corbet@lwn.net, vinod.koul@intel.com, Julia.Lawall@lip6.fr,
	Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, mmarek@suse.cz,
	akpm@linux-foundation.org, bigeasy@linutronix.de,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-mm@kvack.org, cocci@systeme.lip6.fr
Subject: Re: [PATCH 3/4] pci: mm: Add pci_pool_zalloc() call
Date: Tue, 21 Jul 2015 14:38:18 -0500	[thread overview]
Message-ID: <20150721193818.GG21967@google.com> (raw)
In-Reply-To: <1436994883-16563-4-git-send-email-sean.stalley@intel.com>

On Wed, Jul 15, 2015 at 02:14:42PM -0700, Sean O. Stalley wrote:
> Add a wrapper function for pci_pool_alloc() to get zeroed memory.
> 
> Signed-off-by: Sean O. Stalley <sean.stalley@intel.com>

If you get details of managing __GFP_ZERO worked out, I'm fine with this
PCI part of it, and you can merge it along with the rest of the series:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Please capitalize "PCI" in the subject line, like this:

  PCI: mm: Add pci_pool_zalloc() call

> ---
>  include/linux/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 755a2cd..e6ec7d9 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1176,6 +1176,8 @@ int pci_set_vga_state(struct pci_dev *pdev, bool decode,
>  		dma_pool_create(name, &pdev->dev, size, align, allocation)
>  #define	pci_pool_destroy(pool) dma_pool_destroy(pool)
>  #define	pci_pool_alloc(pool, flags, handle) dma_pool_alloc(pool, flags, handle)
> +#define	pci_pool_zalloc(pool, flags, handle) \
> +		dma_pool_zalloc(pool, flags, handle)
>  #define	pci_pool_free(pool, vaddr, addr) dma_pool_free(pool, vaddr, addr)
>  
>  enum pci_dma_burst_strategy {
> -- 
> 1.9.1
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-07-21 19:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 21:14 [Cocci] [PATCH 0/4] mm: add dma_pool_zalloc() & pci_pool_zalloc() Sean O. Stalley
2015-07-15 21:14 ` Sean O. Stalley
2015-07-15 21:14 ` Sean O. Stalley
2015-07-15 21:14 ` [Cocci] [PATCH 1/4] mm: Add support for __GFP_ZERO flag to dma_pool_alloc() Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-15 21:29   ` [Cocci] " Andrew Morton
2015-07-15 21:29     ` Andrew Morton
2015-07-15 21:29     ` Andrew Morton
2015-07-15 23:13     ` [Cocci] " Sean O. Stalley
2015-07-15 23:13       ` Sean O. Stalley
2015-07-15 23:13       ` Sean O. Stalley
2015-07-15 21:14 ` [Cocci] [PATCH 2/4] mm: Add dma_pool_zalloc() call to DMA API Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-15 21:14 ` [Cocci] [PATCH 3/4] pci: mm: Add pci_pool_zalloc() call Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-21 19:38   ` Bjorn Helgaas [this message]
2015-07-21 19:38     ` Bjorn Helgaas
2015-07-21 19:38     ` Bjorn Helgaas
2015-07-15 21:14 ` [Cocci] [PATCH 4/4] coccinelle: mm: scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley
2015-07-15 21:14   ` Sean O. Stalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721193818.GG21967@google.com \
    --to=bhelgaas@google.com \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.