From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"apw@canonical.com" <apw@canonical.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability
Date: Wed, 22 Jul 2015 13:35:46 +0300 [thread overview]
Message-ID: <20150722103546.GO5371@mwanda> (raw)
In-Reply-To: <4538264677374d43961c2d709afb1dd3@SIXPR30MB031.064d.mgd.msft.net>
On Wed, Jul 22, 2015 at 10:09:10AM +0000, Dexuan Cui wrote:
> > I'd suggest you do something like
> >
> > if (ret == -EAGIAIN)
> > return 0;
> > else if (ret)
> > return ret;
> >
> > to make it future-proof (e.g. when a new error is returned by
> > hv_ringbuffer_peek). And a comment would also be useful as it is unclear
> > why we silence errors here.
> Hi Vitaly,
> Thanks!
> I think I made a mistake here:
> the "if (ret != 0) return 0;" should be changed
> to "if (ret != 0) return ret;"
The double negative really doesn't not make the code more complicated.
I like using a quadruple negative instead.
if (ret != 0 != 0)
return ret;
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: "pebolle@tiscali.nl" <pebolle@tiscali.nl>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"apw@canonical.com" <apw@canonical.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability
Date: Wed, 22 Jul 2015 13:35:46 +0300 [thread overview]
Message-ID: <20150722103546.GO5371@mwanda> (raw)
In-Reply-To: <4538264677374d43961c2d709afb1dd3@SIXPR30MB031.064d.mgd.msft.net>
On Wed, Jul 22, 2015 at 10:09:10AM +0000, Dexuan Cui wrote:
> > I'd suggest you do something like
> >
> > if (ret == -EAGIAIN)
> > return 0;
> > else if (ret)
> > return ret;
> >
> > to make it future-proof (e.g. when a new error is returned by
> > hv_ringbuffer_peek). And a comment would also be useful as it is unclear
> > why we silence errors here.
> Hi Vitaly,
> Thanks!
> I think I made a mistake here:
> the "if (ret != 0) return 0;" should be changed
> to "if (ret != 0) return ret;"
The double negative really doesn't not make the code more complicated.
I like using a quadruple negative instead.
if (ret != 0 != 0)
return ret;
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-22 10:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 10:58 [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability Dexuan Cui
2015-07-21 14:07 ` Vitaly Kuznetsov
2015-07-22 10:09 ` Dexuan Cui
2015-07-22 10:09 ` Dexuan Cui
2015-07-22 10:35 ` Dan Carpenter [this message]
2015-07-22 10:35 ` Dan Carpenter
2015-07-23 3:05 ` Dexuan Cui
2015-07-23 3:05 ` Dexuan Cui
2015-07-23 10:10 ` Dan Carpenter
2015-07-23 10:10 ` Dan Carpenter
2015-07-23 10:24 ` Dan Carpenter
2015-07-23 11:05 ` Dexuan Cui
2015-07-24 6:27 ` Sudip Mukherjee
2015-07-24 8:33 ` Dan Carpenter
2015-07-24 8:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722103546.GO5371@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=pebolle@tiscali.nl \
--cc=stefanha@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.