From: Michael Welling <mwelling@ieee.org>
To: Denis Carikli <denis@eukrea.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Eric Bénard" <eric@eukrea.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: adc: mcp320x: Fix NULL pointer.
Date: Wed, 22 Jul 2015 12:18:19 -0500 [thread overview]
Message-ID: <20150722171819.GA18251@deathstar> (raw)
In-Reply-To: <1437581064-9733-1-git-send-email-denis@eukrea.com>
On Wed, Jul 22, 2015 at 06:04:21PM +0200, Denis Carikli wrote:
> Without that fix, adc->chip_info is NULL in mcp320x_read_raw
>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> ---
> drivers/iio/adc/mcp320x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index 8d9c9b9..fccb2dc 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -299,6 +299,7 @@ static int mcp320x_probe(struct spi_device *spi)
> indio_dev->channels = chip_info->channels;
> indio_dev->num_channels = chip_info->num_channels;
>
> + adc->chip_info = chip_info;
> adc->transfer[0].tx_buf = &adc->tx_buf;
> adc->transfer[0].len = sizeof(adc->tx_buf);
> adc->transfer[1].rx_buf = adc->rx_buf;
This issue has already been dealt with.
http://www.gossamer-threads.com/lists/linux/kernel/2214469
> --
> 2.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
To: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
Cc: "Jonathan Cameron"
<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Lars-Peter Clausen"
<lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Eric Bénard" <eric-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] iio: adc: mcp320x: Fix NULL pointer.
Date: Wed, 22 Jul 2015 12:18:19 -0500 [thread overview]
Message-ID: <20150722171819.GA18251@deathstar> (raw)
In-Reply-To: <1437581064-9733-1-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
On Wed, Jul 22, 2015 at 06:04:21PM +0200, Denis Carikli wrote:
> Without that fix, adc->chip_info is NULL in mcp320x_read_raw
>
> Signed-off-by: Denis Carikli <denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/iio/adc/mcp320x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index 8d9c9b9..fccb2dc 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -299,6 +299,7 @@ static int mcp320x_probe(struct spi_device *spi)
> indio_dev->channels = chip_info->channels;
> indio_dev->num_channels = chip_info->num_channels;
>
> + adc->chip_info = chip_info;
> adc->transfer[0].tx_buf = &adc->tx_buf;
> adc->transfer[0].len = sizeof(adc->tx_buf);
> adc->transfer[1].rx_buf = adc->rx_buf;
This issue has already been dealt with.
http://www.gossamer-threads.com/lists/linux/kernel/2214469
> --
> 2.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-22 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 16:04 [PATCH 1/4] iio: adc: mcp320x: Fix NULL pointer Denis Carikli
2015-07-22 16:04 ` Denis Carikli
2015-07-22 16:04 ` [PATCH 2/4] iio: adc: ti-adc128s052: Add adc108s022 ID Denis Carikli
2015-07-22 16:04 ` Denis Carikli
2015-07-22 17:24 ` Michael Welling
2015-07-22 17:24 ` Michael Welling
2015-08-02 17:01 ` Jonathan Cameron
2015-08-02 17:01 ` Jonathan Cameron
2015-07-22 16:04 ` [PATCH 3/4] iio: ti-adc128s052: Documentation: " Denis Carikli
2015-07-22 16:04 ` Denis Carikli
2015-08-02 17:01 ` Jonathan Cameron
2015-08-02 17:01 ` Jonathan Cameron
2015-07-22 16:04 ` [PATCH 4/4] iio: adc: ti-adc128s052: Add devicetree support Denis Carikli
2015-07-22 16:04 ` Denis Carikli
2015-08-02 17:01 ` Jonathan Cameron
2015-08-02 17:01 ` Jonathan Cameron
2015-07-22 17:18 ` Michael Welling [this message]
2015-07-22 17:18 ` [PATCH 1/4] iio: adc: mcp320x: Fix NULL pointer Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722171819.GA18251@deathstar \
--to=mwelling@ieee.org \
--cc=denis@eukrea.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@eukrea.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.