All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Joachim Eastwood <manabian@gmail.com>
Cc: arm@kernel.org, broonie@kernel.org,
	kernel-build-reports@lists.linaro.org,
	linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] memory: pl172: fix modular build
Date: Wed, 22 Jul 2015 16:10:20 -0700	[thread overview]
Message-ID: <20150722231020.GA480@localhost> (raw)
In-Reply-To: <1437603037-18395-1-git-send-email-manabian@gmail.com>

On Thu, Jul 23, 2015 at 12:10:37AM +0200, Joachim Eastwood wrote:
> Building pl172 as a module fails with:
> > ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!
> 
> Because the symbol of_default_bus_match_table isn't exported by the OF
> core code so can't be referenced from modules. Fix this by removing
> the usage of of_default_bus_match_table for now. The side effect of
> this is that child nodes can't use "simple-bus" or "simple-mfd".
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> 
> This should fix the allmod build failure introduces by the
> pl172 driver that Mark encountered. After this fix the driver
> should builds just fine as a module and there is no behavior
> change when boot my devkit either since none of children under
> pl172 uses "simple-bus/mfd" right now.

Thanks, applied.


-Olof

WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] memory: pl172: fix modular build
Date: Wed, 22 Jul 2015 16:10:20 -0700	[thread overview]
Message-ID: <20150722231020.GA480@localhost> (raw)
In-Reply-To: <1437603037-18395-1-git-send-email-manabian@gmail.com>

On Thu, Jul 23, 2015 at 12:10:37AM +0200, Joachim Eastwood wrote:
> Building pl172 as a module fails with:
> > ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!
> 
> Because the symbol of_default_bus_match_table isn't exported by the OF
> core code so can't be referenced from modules. Fix this by removing
> the usage of of_default_bus_match_table for now. The side effect of
> this is that child nodes can't use "simple-bus" or "simple-mfd".
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> 
> This should fix the allmod build failure introduces by the
> pl172 driver that Mark encountered. After this fix the driver
> should builds just fine as a module and there is no behavior
> change when boot my devkit either since none of children under
> pl172 uses "simple-bus/mfd" right now.

Thanks, applied.


-Olof

  reply	other threads:[~2015-07-22 23:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 14:30 next-20150722 build: 2 failures 75 warnings (next-20150722) Build bot for Mark Brown
2015-07-22 18:40 ` Mark Brown
2015-07-22 19:43   ` [PATCH] genirq: Export irq_{get,set}_irqchip_state() Bjorn Andersson
2015-07-22 19:43     ` Bjorn Andersson
2015-07-24 10:53     ` Mark Brown
2015-07-27  6:14     ` [tip:irq/core] genirq: Export irq_[get|set]_irqchip_state() tip-bot for Bjorn Andersson
2015-07-27 13:23     ` [PATCH] genirq: Export irq_{get,set}_irqchip_state() Linus Walleij
2015-07-28 18:49       ` Thomas Gleixner
2015-07-22 18:43 ` next-20150722 build: 2 failures 75 warnings (next-20150722) Mark Brown
2015-07-22 18:43   ` Mark Brown
2015-07-22 21:26   ` Joachim Eastwood
2015-07-22 21:26     ` Joachim Eastwood
2015-07-23 15:54     ` Rob Herring
2015-07-23 15:54       ` Rob Herring
2015-07-22 22:10   ` [PATCH] memory: pl172: fix modular build Joachim Eastwood
2015-07-22 22:10     ` Joachim Eastwood
2015-07-22 23:10     ` Olof Johansson [this message]
2015-07-22 23:10       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150722231020.GA480@localhost \
    --to=olof@lixom.net \
    --cc=arm@kernel.org \
    --cc=broonie@kernel.org \
    --cc=kernel-build-reports@lists.linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-next@vger.kernel.org \
    --cc=manabian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.