Re: [Patch V4 1/3] usb: Add Xen pvUSB protocol description

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Jul 23, 2015 at 06:04:39AM +0200, Juergen Gross wrote:
> On 07/23/2015 01:46 AM, Greg KH wrote:
> >On Tue, Jun 23, 2015 at 08:53:23AM +0200, Juergen Gross wrote:
> >>Add the definition of pvUSB protocol used between the pvUSB frontend in
> >>a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
> >>
> >>This header was originally provided by Fujitsu for Xen based on Linux
> >>2.6.18.
> >>
> >>Changes are:
> >>- adapt to Linux style guide
> >>
> >>Signed-off-by: Juergen Gross <jgross@suse.com>
> >>---
> >>  include/xen/interface/io/usbif.h | 252 +++++++++++++++++++++++++++++++++++++++
> >
> >Why is this a different interface than the existing ones we have today
> >(i.e. usbip?)  Where is it documented?  Do the Xen developers /
> 
> The interface definition is living in the Xen git repository for several
> years now:
> 
> git://xenbits.xen.org/xen.git -> xen/include/public/io/usbif.h

That's header file, not a document describing the api here.

> It is used e.g. in SUSE's xen kernel since 2.6.18.

I am very aware of the amount of Xen crap in SuSE's kernel, don't use
that as an excuse for me to merge it to mainline :)

thanks,

greg k-h