Re: [PATCH] mfd: Add GPIOLIB dependency if INTEL_SOC_PMIC is to be enabled

[Lee Jones <lee.jones@linaro.org>]

On Wed, 22 Jul 2015, Daniel Vetter wrote:

> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote:
> > This is needed as the CRC PMIC has support for Panel
> > enable/diable as gpio which needs 'gpiod_add_lookup_table'
> > and 'gpiod_remove_lookup_table' from gpiolib. This patch
> > can be squashed with below commit in topic/crc-pmic branch
> > 
> > 	commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd
> > 	Author: Shobhit Kumar <shobhit.kumar@intel.com>
> > 	Date:   Fri Jun 26 14:32:05 2015 +0530
> > 
> > 	mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
> > 	signal
> > 
> > 	On some Intel SoC platforms, the panel enable/disable signals
> > 	are controlled by CRC PMIC. Add those control as a new GPIO in a
> > 	lookup table for gpio-crystalcove chip during CRC driver load
> > 
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> 
> Applied, thanks.

You can't just apply changes made to other subsystems willy-nilly.

You should wait for an Ack, despite the triviality of the patch, even
if it's just out of courtesy.

> > ---
> >  drivers/mfd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 6538159..379a420 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -318,6 +318,7 @@ config LPC_SCH
> >  
> >  config INTEL_SOC_PMIC
> >  	bool "Support for Intel Atom SoC PMIC"
> > +	depends on GPIOLIB
> >  	depends on I2C=y
> >  	select MFD_CORE
> >  	select REGMAP_I2C
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx