From: Lee Jones <lee.jones@linaro.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Shobhit Kumar <shobhit.kumar@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] mfd: Add GPIOLIB dependency if INTEL_SOC_PMIC is to be enabled
Date: Thu, 23 Jul 2015 10:15:03 +0100 [thread overview]
Message-ID: <20150723091503.GY3061@x1> (raw)
In-Reply-To: <CAKMK7uG-oUbwN203m8VTd7eaRGU8kexZyCieZ6mwHz-KzgHFGA@mail.gmail.com>
On Thu, 23 Jul 2015, Daniel Vetter wrote:
> On Thu, Jul 23, 2015 at 9:38 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 22 Jul 2015, Daniel Vetter wrote:
> >> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote:
> >> > This is needed as the CRC PMIC has support for Panel
> >> > enable/diable as gpio which needs 'gpiod_add_lookup_table'
> >> > and 'gpiod_remove_lookup_table' from gpiolib. This patch
> >> > can be squashed with below commit in topic/crc-pmic branch
> >> >
> >> > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd
> >> > Author: Shobhit Kumar <shobhit.kumar@intel.com>
> >> > Date: Fri Jun 26 14:32:05 2015 +0530
> >> >
> >> > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
> >> > signal
> >> >
> >> > On some Intel SoC platforms, the panel enable/disable signals
> >> > are controlled by CRC PMIC. Add those control as a new GPIO in a
> >> > lookup table for gpio-crystalcove chip during CRC driver load
> >> >
> >> > Cc: Lee Jones <lee.jones@linaro.org>
> >> > Cc: Linus Walleij <linus.walleij@linaro.org>
> >> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> >>
> >> Applied, thanks.
> >
> > You can't just apply changes made to other subsystems willy-nilly.
> >
> > You should wait for an Ack, despite the triviality of the patch, even
> > if it's just out of courtesy.
>
> Sorry about that, figured getting rid of the compile fail asap is
> better. Should I revert it again and update the pull request?
It's fine. Just please bear it in mind for the future.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-23 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 11:22 [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table' kbuild test robot
2015-07-21 14:05 ` Daniel Vetter
2015-07-21 15:47 ` Kumar, Shobhit
2015-07-21 17:40 ` Daniel Vetter
2015-07-21 18:02 ` Kumar, Shobhit
2015-07-22 8:23 ` Daniel Vetter
2015-07-22 8:31 ` [PATCH] mfd: Add GPIOLIB dependency if INTEL_SOC_PMIC is to be enabled Shobhit Kumar
2015-07-22 9:26 ` Daniel Vetter
2015-07-23 7:38 ` Lee Jones
2015-07-23 7:49 ` Daniel Vetter
2015-07-23 9:15 ` Lee Jones [this message]
2015-07-23 10:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723091503.GY3061@x1 \
--to=lee.jones@linaro.org \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=shobhit.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.