From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers
Date: Thu, 23 Jul 2015 09:59:45 -0700 [thread overview]
Message-ID: <20150723095945.2b4dd59e@urahara> (raw)
In-Reply-To: <1437667657-16954-1-git-send-email-nikolay@cumulusnetworks.com>
On Thu, 23 Jul 2015 09:07:37 -0700
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> + /* Stop hello and hold timer */
> + spin_lock_bh(&br->lock);
> + del_timer(&br->hello_timer);
> + list_for_each_entry(p, &br->port_list, list)
> + del_timer(&p->hold_timer);
> + spin_unlock_bh(&br->lock);
Wouldn't it be easier to use del_timer_sync here?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
davem@davemloft.net, Satish Ashok <sashok@cumulusnetworks.com>
Subject: Re: [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers
Date: Thu, 23 Jul 2015 09:59:45 -0700 [thread overview]
Message-ID: <20150723095945.2b4dd59e@urahara> (raw)
In-Reply-To: <1437667657-16954-1-git-send-email-nikolay@cumulusnetworks.com>
On Thu, 23 Jul 2015 09:07:37 -0700
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> + /* Stop hello and hold timer */
> + spin_lock_bh(&br->lock);
> + del_timer(&br->hello_timer);
> + list_for_each_entry(p, &br->port_list, list)
> + del_timer(&p->hold_timer);
> + spin_unlock_bh(&br->lock);
Wouldn't it be easier to use del_timer_sync here?
next prev parent reply other threads:[~2015-07-23 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 16:07 [Bridge] [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers Nikolay Aleksandrov
2015-07-23 16:07 ` Nikolay Aleksandrov
2015-07-23 16:59 ` Stephen Hemminger [this message]
2015-07-23 16:59 ` Stephen Hemminger
2015-07-23 17:05 ` [Bridge] " Nikolay Aleksandrov
2015-07-23 17:05 ` Nikolay Aleksandrov
2015-07-23 17:13 ` [Bridge] " Stephen Hemminger
2015-07-23 17:13 ` Stephen Hemminger
2015-07-23 17:31 ` [Bridge] " Nikolay Aleksandrov
2015-07-23 17:31 ` Nikolay Aleksandrov
2015-07-23 18:01 ` [Bridge] [PATCH net v2] " Nikolay Aleksandrov
2015-07-23 18:01 ` Nikolay Aleksandrov
2015-07-29 6:33 ` [Bridge] " David Miller
2015-07-29 6:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723095945.2b4dd59e@urahara \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.