From: Pavel Machek <pavel@ucw.cz>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org,
Punit Agrawal <punit.agrawal@arm.com>,
Jean Delvare <jdelvare@suse.de>, Peter Feuerer <peter@piie.net>,
Heiko Stuebner <heiko@sntech.de>,
Lukasz Majewski <l.majewski@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Darren Hart <dvhart@infradead.org>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 14:07:59 +0200 [thread overview]
Message-ID: <20150723120759.GA17690@amd> (raw)
In-Reply-To: <1437463292-24844-1-git-send-email-s.hauer@pengutronix.de>
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
Can we do something like
typedef millicelsius_t int;
...to document the units?
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org,
Punit Agrawal <punit.agrawal@arm.com>,
Jean Delvare <jdelvare@suse.de>, Peter Feuerer <peter@piie.net>,
Heiko Stuebner <heiko@sntech.de>,
Lukasz Majewski <l.majewski@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Darren Hart <dvhart@infradead.org>,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 12:07:59 +0000 [thread overview]
Message-ID: <20150723120759.GA17690@amd> (raw)
In-Reply-To: <1437463292-24844-1-git-send-email-s.hauer@pengutronix.de>
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
Can we do something like
typedef millicelsius_t int;
...to document the units?
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 14:07:59 +0200 [thread overview]
Message-ID: <20150723120759.GA17690@amd> (raw)
In-Reply-To: <1437463292-24844-1-git-send-email-s.hauer@pengutronix.de>
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0?C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0?C.
>
> 'long' is 64bit on several architectures. This is not needed since INT_MAX ?mC
> is above the melting point of all known materials.
Can we do something like
typedef millicelsius_t int;
...to document the units?
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org,
Punit Agrawal <punit.agrawal@arm.com>,
Jean Delvare <jdelvare@suse.de>, Peter Feuerer <peter@piie.net>,
Heiko Stuebner <heiko@sntech.de>,
Lukasz Majewski <l.majewski@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Darren Hart <dvhart@infradead.org>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 14:07:59 +0200 [thread overview]
Message-ID: <20150723120759.GA17690@amd> (raw)
In-Reply-To: <1437463292-24844-1-git-send-email-s.hauer@pengutronix.de>
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
Can we do something like
typedef millicelsius_t int;
...to document the units?
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-07-23 12:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 7:21 [PATCH v2] thermal: consistently use int for temperatures Sascha Hauer
2015-07-21 7:21 ` Sascha Hauer
2015-07-21 7:21 ` [lm-sensors] " Sascha Hauer
2015-07-21 10:52 ` Punit Agrawal
2015-07-21 10:52 ` Punit Agrawal
2015-07-21 10:52 ` Punit Agrawal
2015-07-21 10:52 ` [lm-sensors] " Punit Agrawal
2015-07-21 13:35 ` Zhang, Rui
2015-07-21 13:35 ` Zhang, Rui
2015-07-21 13:35 ` Zhang, Rui
2015-07-21 13:35 ` [lm-sensors] " Zhang, Rui
2015-07-23 10:37 ` Sascha Hauer
2015-07-23 10:37 ` Sascha Hauer
2015-07-23 10:37 ` Sascha Hauer
2015-07-23 10:37 ` [lm-sensors] " Sascha Hauer
2015-07-24 1:31 ` Zhang, Rui
2015-07-24 1:31 ` Zhang, Rui
2015-07-24 1:31 ` Zhang, Rui
2015-07-24 1:31 ` [lm-sensors] " Zhang, Rui
2015-07-24 6:12 ` [PATCH v3] " Sascha Hauer
2015-07-24 6:12 ` Sascha Hauer
2015-07-24 6:12 ` [lm-sensors] " Sascha Hauer
2015-07-23 12:07 ` Pavel Machek [this message]
2015-07-23 12:07 ` [PATCH v2] " Pavel Machek
2015-07-23 12:07 ` Pavel Machek
2015-07-23 12:07 ` [lm-sensors] " Pavel Machek
2015-07-24 6:29 ` Sascha Hauer
2015-07-24 6:29 ` Sascha Hauer
2015-07-24 6:29 ` [lm-sensors] " Sascha Hauer
2015-07-24 13:59 ` Guenter Roeck
2015-07-24 13:59 ` Guenter Roeck
2015-07-24 13:59 ` [lm-sensors] " Guenter Roeck
2015-07-24 22:11 ` Pavel Machek
2015-07-24 22:11 ` Pavel Machek
2015-07-24 22:11 ` [lm-sensors] " Pavel Machek
2015-07-24 22:49 ` Guenter Roeck
2015-07-24 22:49 ` Guenter Roeck
2015-07-24 22:49 ` Guenter Roeck
2015-07-24 22:49 ` [lm-sensors] " Guenter Roeck
2015-07-25 7:01 ` Pavel Machek
2015-07-25 7:01 ` Pavel Machek
2015-07-25 7:01 ` [lm-sensors] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723120759.GA17690@amd \
--to=pavel@ucw.cz \
--cc=dvhart@infradead.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.de \
--cc=l.majewski@samsung.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=maxime.ripard@free-electrons.com \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.