From: Sebastian Reichel <sre@kernel.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig
Date: Fri, 24 Jul 2015 02:16:06 +0200 [thread overview]
Message-ID: <20150724001605.GA1453@earth> (raw)
In-Reply-To: <20150723123553.GE7576@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
Hi Russel,
On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote:
> > Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results
> > in one option less to think about when configuring the kernel.
>
> > -#if defined(CONFIG_ARM_ERRATA_430973) && !defined(CONFIG_ARCH_MULTIPLATFORM)
> > +#ifdef CONFIG_ARM_ERRATA_430973
> > teq r3, #0x00100000 @ only present in r1p*
> > mrceq p15, 0, r0, c1, c0, 1 @ read aux control register
> > orreq r0, r0, #(1 << 6) @ set IBE to 1
>
> NAK. Please read the mailing list history, I'm not repeating myself
> again on this. Thanks.
It's a bit hard to search the mailing list history without a bit
more information.
I guess you prefer to just add the !ARCH_MULTIPLATFORM dependency to
the Kconfig entry without removing the additional check in the code?
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig
Date: Fri, 24 Jul 2015 02:16:06 +0200 [thread overview]
Message-ID: <20150724001605.GA1453@earth> (raw)
In-Reply-To: <20150723123553.GE7576@n2100.arm.linux.org.uk>
Hi Russel,
On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote:
> > Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results
> > in one option less to think about when configuring the kernel.
>
> > -#if defined(CONFIG_ARM_ERRATA_430973) && !defined(CONFIG_ARCH_MULTIPLATFORM)
> > +#ifdef CONFIG_ARM_ERRATA_430973
> > teq r3, #0x00100000 @ only present in r1p*
> > mrceq p15, 0, r0, c1, c0, 1 @ read aux control register
> > orreq r0, r0, #(1 << 6) @ set IBE to 1
>
> NAK. Please read the mailing list history, I'm not repeating myself
> again on this. Thanks.
It's a bit hard to search the mailing list history without a bit
more information.
I guess you prefer to just add the !ARCH_MULTIPLATFORM dependency to
the Kconfig entry without removing the additional check in the code?
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150724/98dc4c4b/attachment.sig>
next prev parent reply other threads:[~2015-07-24 0:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 0:48 [PATCH 0/3] Another Errata 430973 Update Sebastian Reichel
2015-07-23 0:48 ` Sebastian Reichel
2015-07-23 0:48 ` [PATCH 1/3] ARM: OMAP2+: N900: always enable IBE bit Sebastian Reichel
2015-07-23 0:48 ` Sebastian Reichel
2015-07-23 7:28 ` Tony Lindgren
2015-07-23 7:28 ` Tony Lindgren
2015-10-05 13:53 ` Pavel Machek
2015-10-05 13:53 ` Pavel Machek
2015-07-23 0:48 ` [PATCH 2/3] ARM: update errata 430973 documentation Sebastian Reichel
2015-07-23 0:48 ` Sebastian Reichel
2015-07-23 0:48 ` [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig Sebastian Reichel
2015-07-23 0:48 ` Sebastian Reichel
2015-07-23 12:35 ` Russell King - ARM Linux
2015-07-23 12:35 ` Russell King - ARM Linux
2015-07-24 0:16 ` Sebastian Reichel [this message]
2015-07-24 0:16 ` Sebastian Reichel
2015-07-26 22:51 ` Russell King - ARM Linux
2015-07-26 22:51 ` Russell King - ARM Linux
2015-07-27 1:14 ` Sebastian Reichel
2015-07-27 1:14 ` Sebastian Reichel
2015-07-27 9:59 ` Ben Dooks
2015-07-27 9:59 ` Ben Dooks
2015-07-27 10:43 ` Russell King - ARM Linux
2015-07-27 10:43 ` Russell King - ARM Linux
2015-07-27 17:36 ` Sebastian Reichel
2015-07-27 17:36 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724001605.GA1453@earth \
--to=sre@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.