From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
Nitin Kuppelur <nitinkuppelur@gmail.com>,
linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH 1/5] staging: rtl8712: fix buggy size calculation
Date: Fri, 24 Jul 2015 13:52:45 +0300 [thread overview]
Message-ID: <20150724105245.GX5371@mwanda> (raw)
In-Reply-To: <1437712717-7287-2-git-send-email-stillcompiling@gmail.com>
On Thu, Jul 23, 2015 at 09:38:33PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
>
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
>
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
Looks like you are right.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-24 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 4:38 [PATCH 0/5] Joshua Clayton
2015-07-24 4:38 ` [PATCH 1/5] staging: rtl8712: fix buggy size calculation Joshua Clayton
2015-07-24 10:52 ` Dan Carpenter [this message]
2015-07-24 4:38 ` [PATCH 2/5] staging: rtl8712: simplify " Joshua Clayton
2015-07-24 4:52 ` [PATCH 4/5] staging: rtl8712: remove typedefs Joshua Clayton
2015-07-24 4:53 ` [PATCH 5/5] staging: rtl8712: style fix: Joshua Clayton
2015-07-24 10:52 ` Dan Carpenter
2015-07-24 13:06 ` Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724105245.GX5371@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitinkuppelur@gmail.com \
--cc=stillcompiling@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.