From: Sebastian Reichel <sre@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Bruno Prémont" <bonbons@linux-vserver.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree <devicetree@vger.kernel.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v3 4/4] power: Add an axp20x-usb-power driver
Date: Fri, 24 Jul 2015 17:10:21 +0200 [thread overview]
Message-ID: <20150724151020.GH27569@earth> (raw)
In-Reply-To: <1435316357-26606-4-git-send-email-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
Hi,
On Fri, Jun 26, 2015 at 12:59:17PM +0200, Hans de Goede wrote:
> This adds a driver for the usb power_supply bits of the axp20x PMICs.
>
> I initially started writing my own driver, before coming aware of
> Bruno Prémont's excellent earlier RFC with a driver for this.
>
> My driver was lacking CURRENT_MAX and VOLTAGE_MIN support Bruno's
> drvier has, so I've copied the code for those from his driver.
>
> Note that the AC-power-supply and battery charger bits will need separate
> drivers. Each one needs its own devictree child-node so that other
> devicetree nodes can reference the right power-supply, and thus each one
> will get its own mfd-cell / platform_device and platform-driver.
Once the other comments have been taken care of, the driver looks ok
to me.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] power: Add an axp20x-usb-power driver
Date: Fri, 24 Jul 2015 17:10:21 +0200 [thread overview]
Message-ID: <20150724151020.GH27569@earth> (raw)
In-Reply-To: <1435316357-26606-4-git-send-email-hdegoede@redhat.com>
Hi,
On Fri, Jun 26, 2015 at 12:59:17PM +0200, Hans de Goede wrote:
> This adds a driver for the usb power_supply bits of the axp20x PMICs.
>
> I initially started writing my own driver, before coming aware of
> Bruno Pr?mont's excellent earlier RFC with a driver for this.
>
> My driver was lacking CURRENT_MAX and VOLTAGE_MIN support Bruno's
> drvier has, so I've copied the code for those from his driver.
>
> Note that the AC-power-supply and battery charger bits will need separate
> drivers. Each one needs its own devictree child-node so that other
> devicetree nodes can reference the right power-supply, and thus each one
> will get its own mfd-cell / platform_device and platform-driver.
Once the other comments have been taken care of, the driver looks ok
to me.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150724/894209e1/attachment.sig>
next prev parent reply other threads:[~2015-07-24 15:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 10:59 [PATCH v3 1/4] ARM: dts: Add binding documentation for AXP20x pmic usb power supply Hans de Goede
2015-06-26 10:59 ` Hans de Goede
2015-06-26 10:59 ` [PATCH v3 3/4] mfd: axp20x: Add a cell for the usb power_supply part of the axp20x PMICs Hans de Goede
2015-06-26 10:59 ` Hans de Goede
[not found] ` <1435316357-26606-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-06 10:30 ` Maxime Ripard
2015-07-06 10:30 ` Maxime Ripard
2015-07-07 7:01 ` Lee Jones
2015-07-07 7:01 ` Lee Jones
2015-07-07 9:49 ` Hans de Goede
2015-07-07 9:49 ` [linux-sunxi] " Hans de Goede
[not found] ` <559BA0BC.9060409-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-07 10:42 ` Lee Jones
2015-07-07 10:42 ` [linux-sunxi] " Lee Jones
2015-06-26 10:59 ` [PATCH v3 4/4] power: Add an axp20x-usb-power driver Hans de Goede
2015-06-26 10:59 ` Hans de Goede
[not found] ` <1435316357-26606-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-27 5:28 ` Krzysztof Kozlowski
2015-06-27 5:28 ` Krzysztof Kozlowski
[not found] ` <558E3488.9070501-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-06-27 20:25 ` Bruno Prémont
2015-06-27 20:25 ` Bruno Prémont
2015-06-28 10:16 ` Krzysztof Kozlowski
2015-06-28 10:16 ` Krzysztof Kozlowski
2015-07-06 10:40 ` Maxime Ripard
2015-07-06 10:40 ` Maxime Ripard
2015-07-06 12:20 ` Hans de Goede
2015-07-06 12:20 ` [linux-sunxi] " Hans de Goede
2015-07-24 15:10 ` Sebastian Reichel [this message]
2015-07-24 15:10 ` Sebastian Reichel
2015-08-01 7:44 ` Hans de Goede
2015-08-01 7:44 ` Hans de Goede
2015-08-12 12:22 ` Hans de Goede
2015-08-12 12:22 ` Hans de Goede
[not found] ` <1435316357-26606-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 10:59 ` [PATCH v3 2/4] mfd: axp20x: Add missing registers, and mark more registers volatile Hans de Goede
2015-06-26 10:59 ` Hans de Goede
[not found] ` <1435316357-26606-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-06 10:21 ` Maxime Ripard
2015-07-06 10:21 ` Maxime Ripard
2015-07-07 7:01 ` Lee Jones
2015-07-07 7:01 ` Lee Jones
2015-07-24 14:59 ` [PATCH v3 1/4] ARM: dts: Add binding documentation for AXP20x pmic usb power supply Sebastian Reichel
2015-07-24 14:59 ` Sebastian Reichel
2015-08-01 7:43 ` Hans de Goede
2015-08-01 7:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724151020.GH27569@earth \
--to=sre@kernel.org \
--cc=bonbons@linux-vserver.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.