From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] Another posting of the Dove PMU series
Date: Sat, 25 Jul 2015 22:17:23 +0200 [thread overview]
Message-ID: <20150725201723.GD604@lunn.ch> (raw)
In-Reply-To: <20150715185859.GC7557@n2100.arm.linux.org.uk>
On Wed, Jul 15, 2015 at 07:58:59PM +0100, Russell King - ARM Linux wrote:
> What it says in the subject. Not hopeful of a successful outcome, so I'm
> not going to bother wasting time writing stuff here.
Hi Gregory
I took at look at Russell's patches. I rebased them onto -rc1. There
were a few minor merge problems, all easy to fix. I added
Signed-off-by: since i did make changes, but 99.9% of the credit for
these patches is definitely to Russell.
The last patch, which is converting mach-dove to use the new PMU
driver however does not build. With mvebu_v7_defconfig i get:
CC drivers/soc/dove/pmu.o
drivers/soc/dove/pmu.c: In function dove_init_pmu_legacy?:
drivers/soc/dove/pmu.c:400:46: error: IRQ_DOVE_PMU_START undeclared (first use in this function)
irq_domain_associate_many(pmu->irq_domain, IRQ_DOVE_PMU_START,
^
drivers/soc/dove/pmu.c:400:46: note: each undeclared identifier is reported only once for each function it appears in
and dove_defconfig:
CC arch/arm/mach-dove/common.o
arch/arm/mach-dove/common.c:381:15: error: PWR_VPU_PWR_DWN_MASK undeclared here (not in a function)
.pwr_mask = PMU_PWR_VPU_PWR_DWN_MASK,
^
arch/arm/mach-dove/common.c:382:15: error: PMU_SW_RST_VIDEO_MASK undeclared here (not in a function)
.rst_mask = PMU_SW_RST_VIDEO_MASK,
^
arch/arm/mach-dove/common.c:383:15: error: PMU_ISO_VIDEO_MASK undeclared here (not in a function)
.iso_mask = PMU_ISO_VIDEO_MASK,
^
arch/arm/mach-dove/common.c:386:15: error: PMU_PWR_GPU_PWR_DWN_MASK undeclared here (not in a function)
.pwr_mask = PMU_PWR_GPU_PWR_DWN_MASK,
^
arch/arm/mach-dove/common.c:387:15: error: PMU_SW_RST_GPU_MASK undeclared here (not in a function)
.rst_mask = PMU_SW_RST_GPU_MASK,
^
arch/arm/mach-dove/common.c:388:15: error: PMU_ISO_GPU_MASK undeclared here (not in a function)
.iso_mask = PMU_ISO_GPU_MASK,
So i've dropped the last patch.
I boot tested mvebu_v7_defconfig with these patches, and ran the
rtctest, which shows the RTC interrupt it working. The vpu and gpu
power domains are in /sys, but i don't have anything connected to the
HDMI port in order to test them.
You can find the patches here:
https://github.com/lunn/linux.git v4.2-rc1-dove-pmu
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 0/7] Another posting of the Dove PMU series
Date: Sat, 25 Jul 2015 22:17:23 +0200 [thread overview]
Message-ID: <20150725201723.GD604@lunn.ch> (raw)
In-Reply-To: <20150715185859.GC7557-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On Wed, Jul 15, 2015 at 07:58:59PM +0100, Russell King - ARM Linux wrote:
> What it says in the subject. Not hopeful of a successful outcome, so I'm
> not going to bother wasting time writing stuff here.
Hi Gregory
I took at look at Russell's patches. I rebased them onto -rc1. There
were a few minor merge problems, all easy to fix. I added
Signed-off-by: since i did make changes, but 99.9% of the credit for
these patches is definitely to Russell.
The last patch, which is converting mach-dove to use the new PMU
driver however does not build. With mvebu_v7_defconfig i get:
CC drivers/soc/dove/pmu.o
drivers/soc/dove/pmu.c: In function dove_init_pmu_legacyâ:
drivers/soc/dove/pmu.c:400:46: error: IRQ_DOVE_PMU_START undeclared (first use in this function)
irq_domain_associate_many(pmu->irq_domain, IRQ_DOVE_PMU_START,
^
drivers/soc/dove/pmu.c:400:46: note: each undeclared identifier is reported only once for each function it appears in
and dove_defconfig:
CC arch/arm/mach-dove/common.o
arch/arm/mach-dove/common.c:381:15: error: PWR_VPU_PWR_DWN_MASK undeclared here (not in a function)
.pwr_mask = PMU_PWR_VPU_PWR_DWN_MASK,
^
arch/arm/mach-dove/common.c:382:15: error: PMU_SW_RST_VIDEO_MASK undeclared here (not in a function)
.rst_mask = PMU_SW_RST_VIDEO_MASK,
^
arch/arm/mach-dove/common.c:383:15: error: PMU_ISO_VIDEO_MASK undeclared here (not in a function)
.iso_mask = PMU_ISO_VIDEO_MASK,
^
arch/arm/mach-dove/common.c:386:15: error: PMU_PWR_GPU_PWR_DWN_MASK undeclared here (not in a function)
.pwr_mask = PMU_PWR_GPU_PWR_DWN_MASK,
^
arch/arm/mach-dove/common.c:387:15: error: PMU_SW_RST_GPU_MASK undeclared here (not in a function)
.rst_mask = PMU_SW_RST_GPU_MASK,
^
arch/arm/mach-dove/common.c:388:15: error: PMU_ISO_GPU_MASK undeclared here (not in a function)
.iso_mask = PMU_ISO_GPU_MASK,
So i've dropped the last patch.
I boot tested mvebu_v7_defconfig with these patches, and ran the
rtctest, which shows the RTC interrupt it working. The vpu and gpu
power domains are in /sys, but i don't have anything connected to the
HDMI port in order to test them.
You can find the patches here:
https://github.com/lunn/linux.git v4.2-rc1-dove-pmu
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-25 20:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 18:58 [PATCH 0/7] Another posting of the Dove PMU series Russell King - ARM Linux
2015-07-15 18:58 ` Russell King - ARM Linux
2015-07-15 18:59 ` [PATCH 1/7] dt-bindings: add Marvell PMU documentation Russell King
2015-07-15 18:59 ` Russell King
2015-07-15 20:39 ` Rob Herring
2015-07-15 20:39 ` Rob Herring
2015-07-15 20:47 ` Russell King - ARM Linux
2015-07-15 20:47 ` Russell King - ARM Linux
2015-07-15 18:59 ` [PATCH 2/7] ARM: dt: Add PMU node, making PMU child devices childs of this node Russell King
2015-07-15 18:59 ` Russell King
2015-07-15 18:59 ` [PATCH 3/7] ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets Russell King
2015-07-15 18:59 ` [PATCH 4/7] ARM: dt: dove: wire up RTC interrupt Russell King
2015-07-15 18:59 ` Russell King
2015-07-15 18:59 ` [PATCH 5/7] ARM: dt: dove: add video decoder power domain description Russell King
2015-07-15 18:59 ` Russell King
2015-07-15 18:59 ` [PATCH 6/7] ARM: dt: dove: add GPU " Russell King
2015-07-15 18:59 ` Russell King
2015-07-15 18:59 ` [PATCH 7/7] ARM: dove: convert legacy dove to PMU support Russell King
2015-07-25 20:17 ` Andrew Lunn [this message]
2015-07-25 20:17 ` [PATCH 0/7] Another posting of the Dove PMU series Andrew Lunn
2015-07-31 9:51 ` Gregory CLEMENT
2015-07-31 9:51 ` Gregory CLEMENT
2015-07-31 10:58 ` Russell King - ARM Linux
2015-07-31 10:58 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150725201723.GD604@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.