From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Please do not generate patches purely based on checkpatch.
Date: Sat, 25 Jul 2015 15:12:20 -0700 [thread overview]
Message-ID: <20150725221220.GA23301@kroah.com> (raw)
In-Reply-To: <BC5D7C61-8711-4919-9C0B-8D765C7CECA9@gmail.com>
On Sat, Jul 25, 2015 at 04:49:32PM -0400, greg.freemyer at gmail.com wrote:
> On the other hand if you submit a patch that addresses a real bug,
> then simultaneously doing a checkpatch related patch to the same area
> is a very good idea.
No, that would be two different things. Do the bug fix first, and then
the cleanup on a different patch. And even then, most maintainers will
not take a cleanup patch. Stick with subsystems that do take these
types of fixes if you want/like to do them (i.e. drivers/staging/*)
thanks,
greg k-h
next prev parent reply other threads:[~2015-07-25 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 19:50 Please do not generate patches purely based on checkpatch Ahmed Soliman
2015-07-25 20:49 ` greg.freemyer at gmail.com
2015-07-25 22:12 ` Greg KH [this message]
2015-07-26 7:35 ` Yogesh Chaudhari
2015-07-26 17:45 ` Greg KH
2015-07-26 19:32 ` Valdis.Kletnieks at vt.edu
2015-07-26 20:08 ` Yogesh Chaudhari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150725221220.GA23301@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.