All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Please do not generate patches purely based on checkpatch.
Date: Sun, 26 Jul 2015 10:45:08 -0700	[thread overview]
Message-ID: <20150726174508.GA15843@kroah.com> (raw)
In-Reply-To: <CAAOfnZpL3mV7QMVSNPVdcE9XWZrHkSuzXMmc+_NqN4jLfbLzug@mail.gmail.com>

On Sun, Jul 26, 2015 at 01:05:37PM +0530, Yogesh Chaudhari wrote:
> On 26 July 2015 at 03:42, Greg KH <greg@kroah.com> wrote:
> 
> > No, that would be two different things.  Do the bug fix first, and then
> > the cleanup on a different patch.  And even then, most maintainers will
> > not take a cleanup patch.  Stick with subsystems that do take these
> > types of fixes if you want/like to do them (i.e. drivers/staging/*)
> 
> I have come to know that Greg is one of the most liberal maintainers
> in this regard and accepts checkpatch related patches, but other than
> that, it seems to depend on maintainer's choice (which is fine IMHO).
> However, is there a place which documents which maintainers(and/or
> sub-systems) accept checkpatch(or other cleanup related) patches and
> who will reject them outright? Wouldn't it be good to have this
> documented, especially given that using the checkpatch is advised in
> Documentation/SubmitChecklist?

checkpatch is required for when you submit new patches, cleaning up
existing code using checkpatch is not a good idea unless you are sending
patches in for drivers/staging/*

So never use the --file option, unless you know for sure that the
maintainer accepts such patches.  And if you don't know the answer to
that, assume that they do not :)

thanks,

greg k-h

  reply	other threads:[~2015-07-26 17:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-25 19:50 Please do not generate patches purely based on checkpatch Ahmed Soliman
2015-07-25 20:49 ` greg.freemyer at gmail.com
2015-07-25 22:12   ` Greg KH
2015-07-26  7:35     ` Yogesh Chaudhari
2015-07-26 17:45       ` Greg KH [this message]
2015-07-26 19:32       ` Valdis.Kletnieks at vt.edu
2015-07-26 20:08         ` Yogesh Chaudhari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150726174508.GA15843@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.