From: Peter Zijlstra <peterz@infradead.org>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: kernel test robot <ying.huang@intel.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
LKP <lkp@01.org>, LKML <linux-kernel@vger.kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org
Subject: Re: [lkp] [sched/preempt] 103637a5b94: 12.4% fsmark.app_overhead, -1.4% fsmark.files_per_sec
Date: Sun, 26 Jul 2015 11:01:01 +0200 [thread overview]
Message-ID: <20150726090101.GN19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CALYGNiNtLYwts6mu5-yTZTJ_7-FDym=bbtzUv-pmX5yhHWfRuA@mail.gmail.com>
On Sat, Jul 25, 2015 at 07:32:03PM +0300, Konstantin Khlebnikov wrote:
> I guess that's because of cond_resched_lock() usage in nfs_scan_commit_list().
> My patch fixes cond_resched_lock() which never worked since v3.13.
Yeah, I wasn't surprised to see preemptions go up with this patch, not
total throughput suffer a bit due to that.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: lkp@lists.01.org
Subject: Re: [sched/preempt] 103637a5b94: 12.4% fsmark.app_overhead, -1.4% fsmark.files_per_sec
Date: Sun, 26 Jul 2015 11:01:01 +0200 [thread overview]
Message-ID: <20150726090101.GN19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CALYGNiNtLYwts6mu5-yTZTJ_7-FDym=bbtzUv-pmX5yhHWfRuA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
On Sat, Jul 25, 2015 at 07:32:03PM +0300, Konstantin Khlebnikov wrote:
> I guess that's because of cond_resched_lock() usage in nfs_scan_commit_list().
> My patch fixes cond_resched_lock() which never worked since v3.13.
Yeah, I wasn't surprised to see preemptions go up with this patch, not
total throughput suffer a bit due to that.
next prev parent reply other threads:[~2015-07-26 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 6:09 [sched/preempt] 103637a5b94: 12.4% fsmark.app_overhead, -1.4% fsmark.files_per_sec kernel test robot
2015-07-25 6:09 ` [lkp] " kernel test robot
2015-07-25 16:32 ` Konstantin Khlebnikov
2015-07-25 16:32 ` Konstantin Khlebnikov
2015-07-26 9:01 ` Peter Zijlstra [this message]
2015-07-26 9:01 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726090101.GN19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=anna.schumaker@netapp.com \
--cc=khlebnikov@yandex-team.ru \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lkp@01.org \
--cc=trond.myklebust@primarydata.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.