All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Jonathan Corbet <corbet@lwn.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vivek Goyal <vgoyal@redhat.com>
Cc: linux-doc@vger.kernel.org, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michal Hocko <mhocko@kernel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: [V2 PATCH 0/3] x86: Fix panic vs. NMI issues
Date: Mon, 27 Jul 2015 10:58:50 +0900	[thread overview]
Message-ID: <20150727015850.4928.87717.stgit@softrs> (raw)

When an HA cluster software or administrator detects non-response
of a host, they issue an NMI to the host to completely stop current
works and take a crash dump.  If the kernel has already panicked
or is capturing a crash dump at that time, further NMI can cause
a crash dump failure.

To solve this issue, this patch set does two things:

- Don't panic on NMI if the kernel has already panicked
- Introduce "noextnmi" boot option which masks external NMI at the
  boot time (supported only for x86)

V2:
- Use atomic_cmpxchg() instead of current spin_trylock() to exclude
  concurrent accesses to panic() and crash_kexec()
- Don't introduce no-lock version of panic() and crash_kexec()

---

Hidehiro Kawai (3):
      x86/panic: Fix re-entrance problem due to panic on NMI
      kexec: Fix race between panic() and crash_kexec() called directly
      x86/apic: Introduce noextnmi boot option


 Documentation/kernel-parameters.txt |    4 ++++
 arch/x86/kernel/apic/apic.c         |   17 ++++++++++++++++-
 arch/x86/kernel/nmi.c               |   15 +++++++++++----
 include/linux/kernel.h              |    1 +
 kernel/kexec.c                      |   20 ++++++++++++++++++++
 kernel/panic.c                      |   13 ++++++++++---
 6 files changed, 62 insertions(+), 8 deletions(-)


-- 
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: Jonathan Corbet <corbet@lwn.net>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vivek Goyal <vgoyal@redhat.com>
Cc: linux-doc@vger.kernel.org, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michal Hocko <mhocko@kernel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: [V2 PATCH 0/3] x86: Fix panic vs. NMI issues
Date: Mon, 27 Jul 2015 10:58:50 +0900	[thread overview]
Message-ID: <20150727015850.4928.87717.stgit@softrs> (raw)

When an HA cluster software or administrator detects non-response
of a host, they issue an NMI to the host to completely stop current
works and take a crash dump.  If the kernel has already panicked
or is capturing a crash dump at that time, further NMI can cause
a crash dump failure.

To solve this issue, this patch set does two things:

- Don't panic on NMI if the kernel has already panicked
- Introduce "noextnmi" boot option which masks external NMI at the
  boot time (supported only for x86)

V2:
- Use atomic_cmpxchg() instead of current spin_trylock() to exclude
  concurrent accesses to panic() and crash_kexec()
- Don't introduce no-lock version of panic() and crash_kexec()

---

Hidehiro Kawai (3):
      x86/panic: Fix re-entrance problem due to panic on NMI
      kexec: Fix race between panic() and crash_kexec() called directly
      x86/apic: Introduce noextnmi boot option


 Documentation/kernel-parameters.txt |    4 ++++
 arch/x86/kernel/apic/apic.c         |   17 ++++++++++++++++-
 arch/x86/kernel/nmi.c               |   15 +++++++++++----
 include/linux/kernel.h              |    1 +
 kernel/kexec.c                      |   20 ++++++++++++++++++++
 kernel/panic.c                      |   13 ++++++++++---
 6 files changed, 62 insertions(+), 8 deletions(-)


-- 
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group



             reply	other threads:[~2015-07-27  5:11 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  1:58 Hidehiro Kawai [this message]
2015-07-27  1:58 ` [V2 PATCH 0/3] x86: Fix panic vs. NMI issues Hidehiro Kawai
2015-07-27  1:58 ` [V2 PATCH 3/3] x86/apic: Introduce noextnmi boot option Hidehiro Kawai
2015-07-27  1:58   ` Hidehiro Kawai
2015-07-27  1:58 ` [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-07-27  1:58   ` Hidehiro Kawai
2015-07-27 14:34   ` Michal Hocko
2015-07-27 14:34     ` Michal Hocko
2015-07-28  2:02     ` Hidehiro Kawai
2015-07-28  2:02       ` Hidehiro Kawai
2015-07-28  8:01       ` Michal Hocko
2015-07-28  8:01         ` Michal Hocko
2015-07-29  5:48       ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-29  5:48         ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-29  8:23         ` Michal Hocko
2015-07-29  8:23           ` Michal Hocko
2015-07-29  9:09           ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-29  9:09             ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-29  9:21             ` Michal Hocko
2015-07-29  9:21               ` Michal Hocko
2015-07-30  1:45               ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30  1:45                 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30  7:33                 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30  7:33                   ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30  7:55                   ` Michal Hocko
2015-07-30  7:55                     ` Michal Hocko
2015-07-30  8:06                     ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30  8:06                       ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30  7:48                 ` Michal Hocko
2015-07-30  7:48                   ` Michal Hocko
2015-07-30 11:55                   ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30 11:55                     ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30 12:27                     ` Michal Hocko
2015-07-30 12:27                       ` Michal Hocko
2015-07-31 11:23                       ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-31 11:23                         ` 河合英宏 / KAWAI，HIDEHIRO
2015-08-04  8:56                         ` Michal Hocko
2015-08-04  8:56                           ` Michal Hocko
2015-08-04 11:53                           ` 河合英宏 / KAWAI，HIDEHIRO
2015-08-04 11:53                             ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-27  1:58 ` [V2 PATCH 2/3] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-07-27  1:58   ` Hidehiro Kawai
2015-07-27 14:55   ` Michal Hocko
2015-07-27 14:55     ` Michal Hocko
2015-07-28  2:15     ` Hidehiro Kawai
2015-07-28  2:15       ` Hidehiro Kawai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727015850.4928.87717.stgit@softrs \
    --to=hidehiro.kawai.ez@hitachi.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mhocko@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.