All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch -next] lwtunnel: use kfree_skb() instead of vanilla kfree()
@ 2015-07-27  8:07 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-07-27  8:07 UTC (permalink / raw)
  To: David S. Miller, Roopa Prabhu; +Cc: netdev, kernel-janitors

kfree_skb() is correct here.

Fixes: ffce41962ef6 ('lwtunnel: support dst output redirect function')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index bb58826..5f7fae7 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -205,7 +205,7 @@ int __lwtunnel_output(struct sock *sk, struct sk_buff *skb,
 	return ret;
 
 drop:
-	kfree(skb);
+	kfree_skb(skb);
 
 	return ret;
 }

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [patch -next] lwtunnel: use kfree_skb() instead of vanilla kfree()
@ 2015-07-27  8:07 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-07-27  8:07 UTC (permalink / raw)
  To: David S. Miller, Roopa Prabhu; +Cc: netdev, kernel-janitors

kfree_skb() is correct here.

Fixes: ffce41962ef6 ('lwtunnel: support dst output redirect function')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index bb58826..5f7fae7 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -205,7 +205,7 @@ int __lwtunnel_output(struct sock *sk, struct sk_buff *skb,
 	return ret;
 
 drop:
-	kfree(skb);
+	kfree_skb(skb);
 
 	return ret;
 }

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch -next] lwtunnel: use kfree_skb() instead of vanilla kfree()
  2015-07-27  8:07 ` Dan Carpenter
@ 2015-07-27  8:25   ` David Miller
  -1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-07-27  8:25 UTC (permalink / raw)
  To: dan.carpenter; +Cc: roopa, netdev, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 27 Jul 2015 11:07:47 +0300

> kfree_skb() is correct here.
> 
> Fixes: ffce41962ef6 ('lwtunnel: support dst output redirect function')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oops, good catch.  Applied, thanks Dan.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch -next] lwtunnel: use kfree_skb() instead of vanilla kfree()
@ 2015-07-27  8:25   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-07-27  8:25 UTC (permalink / raw)
  To: dan.carpenter; +Cc: roopa, netdev, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 27 Jul 2015 11:07:47 +0300

> kfree_skb() is correct here.
> 
> Fixes: ffce41962ef6 ('lwtunnel: support dst output redirect function')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oops, good catch.  Applied, thanks Dan.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-27  8:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-27  8:07 [patch -next] lwtunnel: use kfree_skb() instead of vanilla kfree() Dan Carpenter
2015-07-27  8:07 ` Dan Carpenter
2015-07-27  8:25 ` David Miller
2015-07-27  8:25   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.