All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Haibo Chen <haibo.chen@freescale.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
	"hadess@hadess.net" <hadess@hadess.net>,
	"mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
	"mamlinav@gmail.com" <mamlinav@gmail.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jonathar@broadcom.com" <jonathar@broadcom.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	"christian.gmeiner@gmail.com" <christian.gmeiner@gmail.com>,
	"scott.liu@emc.com.tw" <scott.liu@emc.com.tw>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	benjamin.tissoire
Subject: Re: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc
Date: Mon, 27 Jul 2015 12:25:47 +0100	[thread overview]
Message-ID: <20150727112547.GE9169@leverpostej> (raw)
In-Reply-To: <1437996407-27266-3-git-send-email-haibo.chen@freescale.com>

On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote:
> Here we apply required documentation for the imx6ul touch screen
> controller driver which describe available properties and how to
> use them.
> 
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> ---
>  .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt   | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> new file mode 100644
> index 0000000..e34d752
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> @@ -0,0 +1,14 @@
> +* Freescale i.MX6UL Touch Controller
> +
> +Required properties:
> +- compatible: must be "fsl,imx6ul-tsc"
> +

What about all the other properties in the example?

> +Example:
> +	&tsc {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_tsc>;
> +		status = "okay";
> +		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> +		measure_delay_time = <0xfff>;
> +		pre_charge_time = <0xffff>;

Thiose underscores should be dashes, and all the properties should be
documented.

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc
Date: Mon, 27 Jul 2015 12:25:47 +0100	[thread overview]
Message-ID: <20150727112547.GE9169@leverpostej> (raw)
In-Reply-To: <1437996407-27266-3-git-send-email-haibo.chen@freescale.com>

On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote:
> Here we apply required documentation for the imx6ul touch screen
> controller driver which describe available properties and how to
> use them.
> 
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> ---
>  .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt   | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> new file mode 100644
> index 0000000..e34d752
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> @@ -0,0 +1,14 @@
> +* Freescale i.MX6UL Touch Controller
> +
> +Required properties:
> +- compatible: must be "fsl,imx6ul-tsc"
> +

What about all the other properties in the example?

> +Example:
> +	&tsc {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_tsc>;
> +		status = "okay";
> +		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> +		measure_delay_time = <0xfff>;
> +		pre_charge_time = <0xffff>;

Thiose underscores should be dashes, and all the properties should be
documented.

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Haibo Chen <haibo.chen@freescale.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
	"hadess@hadess.net" <hadess@hadess.net>,
	"mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
	"mamlinav@gmail.com" <mamlinav@gmail.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jonathar@broadcom.com" <jonathar@broadcom.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	"christian.gmeiner@gmail.com" <christian.gmeiner@gmail.com>,
	"scott.liu@emc.com.tw" <scott.liu@emc.com.tw>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
	"sebastien.szymanski@armadeus.com"
	<sebastien.szymanski@armadeus.com>,
	"sbranden@broadcom.com" <sbranden@broadcom.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc
Date: Mon, 27 Jul 2015 12:25:47 +0100	[thread overview]
Message-ID: <20150727112547.GE9169@leverpostej> (raw)
In-Reply-To: <1437996407-27266-3-git-send-email-haibo.chen@freescale.com>

On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote:
> Here we apply required documentation for the imx6ul touch screen
> controller driver which describe available properties and how to
> use them.
> 
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> ---
>  .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt   | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> new file mode 100644
> index 0000000..e34d752
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> @@ -0,0 +1,14 @@
> +* Freescale i.MX6UL Touch Controller
> +
> +Required properties:
> +- compatible: must be "fsl,imx6ul-tsc"
> +

What about all the other properties in the example?

> +Example:
> +	&tsc {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_tsc>;
> +		status = "okay";
> +		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> +		measure_delay_time = <0xfff>;
> +		pre_charge_time = <0xffff>;

Thiose underscores should be dashes, and all the properties should be
documented.

Mark.

  reply	other threads:[~2015-07-27 11:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 11:26 [PATCH 0/5] Add imx6ul touch screen controller support Haibo Chen
2015-07-27 11:26 ` Haibo Chen
2015-07-27 11:26 ` Haibo Chen
2015-07-27 11:26 ` [PATCH 1/5] input: touchscreen: add imx6ul_tsc driver support Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 22:05   ` Dmitry Torokhov
2015-07-27 22:05     ` Dmitry Torokhov
2015-07-28  9:17     ` Chen Bough
2015-07-28  9:17       ` Chen Bough
2015-07-28  9:17       ` Chen Bough
2015-07-27 11:26 ` [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:25   ` Mark Rutland [this message]
2015-07-27 11:25     ` Mark Rutland
2015-07-27 11:25     ` Mark Rutland
2015-07-28  8:48     ` Chen Bough
2015-07-28  8:48       ` Chen Bough
2015-07-28  8:48       ` Chen Bough
2015-07-27 11:26 ` [PATCH 3/5] ARM: imx_v6_v7_defconfig: enable imx6ul_tsc Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:26 ` [PATCH 4/5] ARM: dts: imx6ul.dtsi: add TSC support Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:28   ` Mark Rutland
2015-07-27 11:28     ` Mark Rutland
2015-07-27 11:28     ` Mark Rutland
2015-07-27 11:26 ` [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 11:26   ` Haibo Chen
2015-07-27 14:13   ` Shawn Guo
2015-07-27 14:13     ` Shawn Guo
2015-07-28  8:50     ` Chen Bough
2015-07-28  8:50       ` Chen Bough
2015-07-28  8:50       ` Chen Bough

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727112547.GE9169@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=arnd@arndb.de \
    --cc=christian.gmeiner@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=hadess@hadess.net \
    --cc=haibo.chen@freescale.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hdegoede@redhat.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jonathar@broadcom.com \
    --cc=kernel@pengutronix.de \
    --cc=linux@arm.linux.org.uk \
    --cc=mamlinav@gmail.com \
    --cc=mchehab@osg.samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=scott.liu@emc.com.tw \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.