All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ?
Date: Mon, 27 Jul 2015 08:14:13 -0400	[thread overview]
Message-ID: <20150727121413.GA2312@redhat.com> (raw)
In-Reply-To: <DUB128-W57EEA6D50E9781025705219C8E0@phx.gbl>

On Mon, Jul 27 2015 at  3:00P -0400,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> [linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction always evaluates to false: !EXPR && EXPR.
> 
> Source code is
> 
>   if (!mq->cache_hit_bits && mq->cache_hit_bits) {
> 
> Maybe
> 
>   if (!mq->cache_hit_bits) {
> 
> was intended.

Thanks, was fixed with this, will go upstream for 4.2-rc5:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=134bf30c06f057d6b8d90132e8f8b3cd2be79572

      reply	other threads:[~2015-07-27 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  7:00 linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ? David Binderman
2015-07-27 12:14 ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727121413.GA2312@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dcb314@hotmail.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.