linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ?

All of lore.kernel.org
 help / color / mirror / Atom feed

* linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ?
@ 2015-07-27  7:00 David Binderman
  2015-07-27 12:14 ` Mike Snitzer
  0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2015-07-27  7:00 UTC (permalink / raw)
  To: Alasdair Kergon, Mike Snitzer, dm-devel@redhat.com

Hello there,

[linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction always evaluates to false: !EXPR && EXPR.

Source code is

  if (!mq->cache_hit_bits && mq->cache_hit_bits) {

Maybe

  if (!mq->cache_hit_bits) {

was intended.


Regards

David Binderman


 		 	   		  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ?
  2015-07-27  7:00 linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ? David Binderman
@ 2015-07-27 12:14 ` Mike Snitzer
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2015-07-27 12:14 UTC (permalink / raw)
  To: David Binderman; +Cc: dm-devel@redhat.com, Alasdair Kergon

On Mon, Jul 27 2015 at  3:00P -0400,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> [linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction always evaluates to false: !EXPR && EXPR.
> 
> Source code is
> 
>   if (!mq->cache_hit_bits && mq->cache_hit_bits) {
> 
> Maybe
> 
>   if (!mq->cache_hit_bits) {
> 
> was intended.

Thanks, was fixed with this, will go upstream for 4.2-rc5:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=134bf30c06f057d6b8d90132e8f8b3cd2be79572

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-27 12:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-27  7:00 linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ? David Binderman
2015-07-27 12:14 ` Mike Snitzer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.