Re: [PATCH v8 0/5] mtd: nand: vf610_nfc: Freescale NFC for VF610

[Shawn Guo <shawnguo@kernel.org>]

On Mon, Jul 27, 2015 at 06:42:40PM +0200, Stefan Agner wrote:
> The eigth revision fixes some rough spots in the device trees.
> 
> More information and the full test log of earlier patchset version
> can be found in the cover letter of the last revision v6:
> http://thread.gmane.org/gmane.linux.kernel/1979868
> 
> Changes since v7:
> - vf610-twr.dts: Moved NFC pinmux into the existing iomuxc node
>   and sort new nfc node behind the existing iomuxc node as well.
> - vf610-twr.dts/vf-colibri.dtsi: Dropped _1 suffixes

Now I'm happy with the dts part and waiting for mtd part to be accepted
to actually apply them.

Shawn

> 
> Changes since v6:
> - Rebased ontop of l2-mtd/master (v4.2-rc1 based)
> - Removed HAVE_NAND_VF610_NFC and use depends on. This made
>   "[PATCH v6 4/6] ARM: vf610: enable NAND Flash Controller" unnecessary
> 
> Changes since v5:
> - Removed fsl,mpc5125-nfc compatible string
> - Removed readl/writel_relaxed
> - Change interface of vf610_nfc_transfer_size to match other accessors
> 
> Changes since v4:
> - Rebased ontop of l2-mtd/master (v4.1-rc4 based)
> - Eliminate unnecessary page read (NAND_CMD_SEQIN) since the driver does
>   not support sub-page writes anyway (improves write performance)
> - Support ONFI by enabling READID command with offset and parameter page
>   reads (CMD_PARAM)
> - Change to dedicated read_page/write_page function, enables raw writes
> - Use __LITTLE_ENDIAN to distingush between LE/BE relevant statements
> - Eliminated vf610_nfc_probe_dt in favor of common DT init code
> - Use wait_for_completion_timeout
> - Some style fixes (spaces, etc.)
> 
> Changes since v3:
> - Make the driver selectable when COMPILE_TEST is set
> - Fix compile error due to superfluous ECC_STATUS configuration in initial
>   patch (without ECC correction ECC_STATUS does not need to be configured)
> - Remove custom BBT pattern and switch to in-band BBT in the initial patch
> - Include two bug fixes, for details see the corresponding U-Boot patches:
>   http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/215802
> 
> Changes since v2:
> - Updated binding documentation
> 
> Changes since v1:
> - Nest nfc_config struct within the main nfc struct
> - Use assigned clock binding to specify NFC clock
> - Rebased ontop of MSCM IR patchset (driver parts have been merged)
> - Split out arch Kconfig in a separate config
> - Fix module license
> - Updated MAINTAINERS
> 
> Changes since RFC (Bill Pringlemeir):
> - Renamed driver from fsl_nfc to vf610_nfc
> - Use readl/writel for all register in accessor functions
> - Optimized field accessor functions
> - Implemented PM (suspend/resume) functions
> - Implemented basic support for ECC strength/ECC step size from dt
> - Improved performance of count_written_bits by using hweight32
> - Support ECC with 60-bytes to correct up to 32 bit errors
> - Changed to in-band BBT (NAND_BBT_NO_OOB) which also allows ECC modes
>   which uses up to 60 bytes on 64 byte OOB
> - Removed custom (downstream) BBT pattern since BBT table won't be
>   compatible anyway (due to the change above)
> 
> Stefan Agner (5):
>   mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
>   mtd: nand: vf610_nfc: add hardware BCH-ECC support
>   mtd: nand: vf610_nfc: add device tree bindings
>   ARM: dts: vf610twr: add NAND flash controller peripherial
>   ARM: dts: vf-colibri: enable NAND flash controller
> 
>  .../devicetree/bindings/mtd/vf610-nfc.txt          |  45 ++
>  MAINTAINERS                                        |   6 +
>  arch/arm/boot/dts/vf-colibri.dtsi                  |  32 +
>  arch/arm/boot/dts/vf610-twr.dts                    |  40 +
>  arch/arm/boot/dts/vfxxx.dtsi                       |   8 +
>  drivers/mtd/nand/Kconfig                           |  11 +
>  drivers/mtd/nand/Makefile                          |   1 +
>  drivers/mtd/nand/vf610_nfc.c                       | 839 +++++++++++++++++++++
>  8 files changed, 982 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/vf610-nfc.txt
>  create mode 100644 drivers/mtd/nand/vf610_nfc.c
> 
> -- 
> 2.4.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>