From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org, Guenter Roeck <linux@roeck-us.net>,
Matthew Fortune <matthew.fortune@imgtec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/16] MIPS: remove outdated comments in sigcontext.h
Date: Tue, 28 Jul 2015 10:39:05 +0200 [thread overview]
Message-ID: <20150728083905.GE30938@linux-mips.org> (raw)
In-Reply-To: <1438027107-24420-2-git-send-email-paul.burton@imgtec.com>
On Mon, Jul 27, 2015 at 12:58:12PM -0700, Paul Burton wrote:
> The offsets to various fields within struct sigcontext are declared
> using asm-offsets.c these days, so drop the outdated comment that talks
> about keeping in sync with a no longer present file.
The file was renamed not removed and the comment still applies. I've
recently fixed the comment so this patch again is against would reject
aside of being wrong so I'm dropping it.
> diff --git a/arch/mips/include/uapi/asm/sigcontext.h b/arch/mips/include/uapi/asm/sigcontext.h
> index 6c9906f..ae78902 100644
> --- a/arch/mips/include/uapi/asm/sigcontext.h
> +++ b/arch/mips/include/uapi/asm/sigcontext.h
> @@ -14,10 +14,6 @@
>
> #if _MIPS_SIM == _MIPS_SIM_ABI32
>
> -/*
> - * Keep this struct definition in sync with the sigcontext fragment
> - * in arch/mips/tools/offset.c
> - */
> struct sigcontext {
> unsigned int sc_regmask; /* Unused */
> unsigned int sc_status; /* Unused */
> @@ -45,9 +41,6 @@ struct sigcontext {
>
> #include <linux/posix_types.h>
> /*
> - * Keep this struct definition in sync with the sigcontext fragment
> - * in arch/mips/tools/offset.c
> - *
Ralf
next prev parent reply other threads:[~2015-07-28 8:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 19:58 [PATCH v2 00/16] MSA vector context signal handling & HWCAPs Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 01/16] MIPS: remove outdated comments in sigcontext.h Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-28 8:39 ` Ralf Baechle [this message]
2015-07-27 19:58 ` [PATCH v2 02/16] MIPS: simplify EVA FP context handling code Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 03/16] MIPS: add offsets to sigcontext FP fields to struct mips_abi Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 04/16] MIPS: use struct mips_abi offsets to save FP context Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 05/16] MIPS: move FP usage checks into protected_{save,restore}_fp_context Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 06/16] MIPS: skip odd double FP registers when copying FP32 sigcontext Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 07/16] MIPS: use common FP sigcontext code for O32 compat Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 08/16] MIPS: remove unused {get,put}_sigset functions Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 09/16] MIPS: indicate FP mode in sigcontext sc_used_math Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 10/16] MIPS: add definitions for extended context Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 11/16] MIPS: save MSA extended context around signals Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 12/16] MIPS: AT_HWCAP aux vector infrastructure Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 13/16] MIPS: advertise MIPSr6 via HWCAP when appropriate Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 14/16] MIPS: advertise MSA support via HWCAP when present Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 15/16] MIPS: require O32 FP64 support for MIPS64 with O32 compat Paul Burton
2015-07-27 19:58 ` Paul Burton
2015-07-27 19:58 ` [PATCH v2 16/16] MIPS: drop EXPERIMENTAL tag from O32+FP64 & MSA Paul Burton
2015-07-27 19:58 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728083905.GE30938@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@roeck-us.net \
--cc=matthew.fortune@imgtec.com \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.