* [patch] drm/amdgpu: information leak in amdgpu_info_ioctl()
@ 2015-07-28 15:51 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-07-28 15:51 UTC (permalink / raw)
To: David Airlie, Leo Liu
Cc: Jammy Zhou, Christian König, Ken Wang, Alex Deucher,
yanyang1, Marek Olšák, dri-devel, kernel-janitors
We recently changed the drm_amdgpu_info_device struct so now there is
a 4 byte hole at the end. We need to initialize it so we don't disclose
secret information from the stack.
Fixes: fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index d9de73a..81d60a9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
return n ? -EFAULT : 0;
}
case AMDGPU_INFO_DEV_INFO: {
- struct drm_amdgpu_info_device dev_info;
+ struct drm_amdgpu_info_device dev_info = {};
struct amdgpu_cu_info cu_info;
dev_info.device_id = dev->pdev->device;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] drm/amdgpu: information leak in amdgpu_info_ioctl()
@ 2015-07-28 15:51 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-07-28 15:51 UTC (permalink / raw)
To: David Airlie, Leo Liu
Cc: Jammy Zhou, Christian König, Ken Wang, Alex Deucher,
yanyang1, Marek Olšák, dri-devel, kernel-janitors
We recently changed the drm_amdgpu_info_device struct so now there is
a 4 byte hole at the end. We need to initialize it so we don't disclose
secret information from the stack.
Fixes: fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index d9de73a..81d60a9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
return n ? -EFAULT : 0;
}
case AMDGPU_INFO_DEV_INFO: {
- struct drm_amdgpu_info_device dev_info;
+ struct drm_amdgpu_info_device dev_info = {};
struct amdgpu_cu_info cu_info;
dev_info.device_id = dev->pdev->device;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] drm/amdgpu: information leak in amdgpu_info_ioctl()
2015-07-28 15:51 ` Dan Carpenter
@ 2015-07-29 1:41 ` Alex Deucher
-1 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2015-07-29 1:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Leo Liu, Marek Olšák, kernel-janitors,
Maling list - DRI developers, yanyang1, Alex Deucher, Ken Wang,
Christian König
On Tue, Jul 28, 2015 at 11:51 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We recently changed the drm_amdgpu_info_device struct so now there is
> a 4 byte hole at the end. We need to initialize it so we don't disclose
> secret information from the stack.
>
> Fixes: fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index d9de73a..81d60a9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
> return n ? -EFAULT : 0;
> }
> case AMDGPU_INFO_DEV_INFO: {
> - struct drm_amdgpu_info_device dev_info;
> + struct drm_amdgpu_info_device dev_info = {};
> struct amdgpu_cu_info cu_info;
>
> dev_info.device_id = dev->pdev->device;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] drm/amdgpu: information leak in amdgpu_info_ioctl()
@ 2015-07-29 1:41 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2015-07-29 1:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Leo Liu, Marek Olšák, kernel-janitors,
Maling list - DRI developers, yanyang1, Alex Deucher, Ken Wang,
Christian König
On Tue, Jul 28, 2015 at 11:51 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We recently changed the drm_amdgpu_info_device struct so now there is
> a 4 byte hole at the end. We need to initialize it so we don't disclose
> secret information from the stack.
>
> Fixes: fa92754e9c47 ('drm/amdgpu: add VCE harvesting instance query')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index d9de73a..81d60a9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -423,7 +423,7 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file
> return n ? -EFAULT : 0;
> }
> case AMDGPU_INFO_DEV_INFO: {
> - struct drm_amdgpu_info_device dev_info;
> + struct drm_amdgpu_info_device dev_info = {};
> struct amdgpu_cu_info cu_info;
>
> dev_info.device_id = dev->pdev->device;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-29 1:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-28 15:51 [patch] drm/amdgpu: information leak in amdgpu_info_ioctl() Dan Carpenter
2015-07-28 15:51 ` Dan Carpenter
2015-07-29 1:41 ` Alex Deucher
2015-07-29 1:41 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.