All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: "Sahita, Ravi" <ravi.sahita@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	"tim@xen.org" <tim@xen.org>,
	"White, Edmund H" <edmund.h.white@intel.com>,
	Jan Beulich <JBeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Regression in guest destruction caused by altp2m
Date: Wed, 29 Jul 2015 11:03:31 +0100	[thread overview]
Message-ID: <20150729100330.GV5111@zion.uk.xensource.com> (raw)
In-Reply-To: <DBC12B0F5509554280826E40BCDEE8BE54FEB4C7@ORSMSX104.amr.corp.intel.com>

On Mon, Jul 27, 2015 at 11:26:36PM +0000, Sahita, Ravi wrote:
[...]
> >> This makes me think it doesn't matter if I do "xl destroy" or just
> >> normal shutdown. And another test to normally shutdown guest confirmed
> >> that.
> >>
> >> The machine I have is quite old and doesn't support EPT. The real
> >> issues seems to be that you failed to properly disable that feature
> >> for old machines.
> >
> >The altp2m feature is designed (and implemented) to be emulated on
> >systems lacking hardware capabilities.
> >
> >As such, teardown is necessary even on older systems, but I would agree that
> >there appears to be a bug.
> 
> Yes - 
> the check for hvm_altp2m_supported() before altp2m_vcpu_destroy() was missing - will send a patch tonight.
> 

Hi Ravi

Any update on this? This is a blocker for the release. Please fix it as
soon as possible.

Wei.

> Ravi
> 
> 
> >
> >~Andrew

  reply	other threads:[~2015-07-29 10:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 15:18 Regression in guest destruction caused by altp2m Wei Liu
2015-07-27 18:09 ` Wei Liu
2015-07-27 23:21   ` Andrew Cooper
2015-07-27 23:26     ` Sahita, Ravi
2015-07-29 10:03       ` Wei Liu [this message]
2015-07-29 16:41         ` Sahita, Ravi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729100330.GV5111@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=edmund.h.white@intel.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ravi.sahita@intel.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.