From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jayachandran C <jchandra@broadcom.com>
Cc: Will Deacon <Will.Deacon@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Liviu Dudau <Liviu.Dudau@arm.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
Ming Lei <ming.lei@canonical.com>
Subject: Re: [PATCH v3 2/2] PCI: generic: add arm64 support
Date: Wed, 29 Jul 2015 17:25:11 +0100 [thread overview]
Message-ID: <20150729162510.GA29159@red-moon> (raw)
In-Reply-To: <1438183681-30519-2-git-send-email-jchandra@broadcom.com>
On Wed, Jul 29, 2015 at 04:28:01PM +0100, Jayachandran C wrote:
> Enable pci-host-generic driver available in arm64. This needs
> drivers/pci/setup-irq.o as well.
You should move the Kconfig change to the previous patch,
and create another a stand-alone patch (that you will send as
first in the patch sequence) to compile setup-irq.c on ARM64.
Thanks,
Lorenzo
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> drivers/pci/Makefile | 1 +
> drivers/pci/host/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 73e4af4..be3f631 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -33,6 +33,7 @@ obj-$(CONFIG_PCI_IOV) += iov.o
> #
> obj-$(CONFIG_ALPHA) += setup-irq.o
> obj-$(CONFIG_ARM) += setup-irq.o
> +obj-$(CONFIG_ARM64) += setup-irq.o
> obj-$(CONFIG_UNICORE32) += setup-irq.o
> obj-$(CONFIG_SUPERH) += setup-irq.o
> obj-$(CONFIG_MIPS) += setup-irq.o
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index c132bdd..675c2d1 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -53,7 +53,7 @@ config PCI_RCAR_GEN2_PCIE
>
> config PCI_HOST_GENERIC
> bool "Generic PCI host controller"
> - depends on ARM && OF
> + depends on (ARM || ARM64) && OF
> help
> Say Y here if you want to support a simple generic PCI host
> controller, such as the one emulated by kvmtool.
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] PCI: generic: add arm64 support
Date: Wed, 29 Jul 2015 17:25:11 +0100 [thread overview]
Message-ID: <20150729162510.GA29159@red-moon> (raw)
In-Reply-To: <1438183681-30519-2-git-send-email-jchandra@broadcom.com>
On Wed, Jul 29, 2015 at 04:28:01PM +0100, Jayachandran C wrote:
> Enable pci-host-generic driver available in arm64. This needs
> drivers/pci/setup-irq.o as well.
You should move the Kconfig change to the previous patch,
and create another a stand-alone patch (that you will send as
first in the patch sequence) to compile setup-irq.c on ARM64.
Thanks,
Lorenzo
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> drivers/pci/Makefile | 1 +
> drivers/pci/host/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 73e4af4..be3f631 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -33,6 +33,7 @@ obj-$(CONFIG_PCI_IOV) += iov.o
> #
> obj-$(CONFIG_ALPHA) += setup-irq.o
> obj-$(CONFIG_ARM) += setup-irq.o
> +obj-$(CONFIG_ARM64) += setup-irq.o
> obj-$(CONFIG_UNICORE32) += setup-irq.o
> obj-$(CONFIG_SUPERH) += setup-irq.o
> obj-$(CONFIG_MIPS) += setup-irq.o
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index c132bdd..675c2d1 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -53,7 +53,7 @@ config PCI_RCAR_GEN2_PCIE
>
> config PCI_HOST_GENERIC
> bool "Generic PCI host controller"
> - depends on ARM && OF
> + depends on (ARM || ARM64) && OF
> help
> Say Y here if you want to support a simple generic PCI host
> controller, such as the one emulated by kvmtool.
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-07-29 16:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 15:28 [PATCH v3 1/2] PCI: generic: remove dependency on hw_pci Jayachandran C
2015-07-29 15:28 ` Jayachandran C
2015-07-29 15:28 ` [PATCH v3 2/2] PCI: generic: add arm64 support Jayachandran C
2015-07-29 15:28 ` Jayachandran C
2015-07-29 16:25 ` Lorenzo Pieralisi [this message]
2015-07-29 16:25 ` Lorenzo Pieralisi
2015-07-30 9:28 ` [PATCH v3 1/2] PCI: generic: remove dependency on hw_pci Lorenzo Pieralisi
2015-07-30 9:28 ` Lorenzo Pieralisi
2015-07-30 10:13 ` Jayachandran C.
2015-07-30 13:49 ` Lorenzo Pieralisi
2015-07-30 13:49 ` Lorenzo Pieralisi
2015-07-30 13:35 ` Lorenzo Pieralisi
2015-07-30 13:35 ` Lorenzo Pieralisi
2015-07-31 16:07 ` Jayachandran C.
2015-07-31 16:27 ` Lorenzo Pieralisi
2015-07-31 16:27 ` Lorenzo Pieralisi
2015-08-03 13:11 ` Will Deacon
2015-08-03 13:11 ` Will Deacon
2015-08-03 23:24 ` Bjorn Helgaas
2015-08-03 23:24 ` Bjorn Helgaas
2015-07-30 16:45 ` Rob Herring
2015-07-30 16:45 ` Rob Herring
2015-08-04 7:35 ` Pavel Fedin
2015-08-04 7:35 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729162510.GA29159@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jchandra@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.