Re: [PATCH 5/6] ASoC: Intel: Skylake: Add DSP module init and binding routines

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1227 bytes --]

On Wed, Jul 29, 2015 at 01:35:14PM +0100, Mark Brown wrote:
> On Tue, Jul 21, 2015 at 11:53:59PM +0530, Vinod Koul wrote:
> 
> > +int skl_bind_unbind_modules(struct skl_sst *ctx, struct skl_module_cfg
> > +	*src_module, struct skl_module_cfg *dst_module, bool bind)
> > +{
> > +	dev_dbg(ctx->dev, "%s: src module_id = %d  src_instance=%d\n",
> > +		__func__, src_module->id.module_id, src_module->id.instance_id);
> > +	dev_dbg(ctx->dev, "%s: dst_module=%d dst_instacne=%d\n", __func__,
> > +		 dst_module->id.module_id, dst_module->id.instance_id);
> > +
> > +	dev_dbg(ctx->dev, "src_module state = %d dst module state = %d\n",
> > +		src_module->m_state, dst_module->m_state);
> > +
> > +	if (bind)
> > +		return skl_bind_modules(ctx, src_module, dst_module);
> > +	else
> > +		return skl_unbind_modules(ctx, src_module, dst_module);
> > +}
> 
> I'm not sure I understand the purpose of this function - why not just
> use the bind and unbind functions directly if they share nothing?
Yes that can be done, this allows us to have common dump and invoking
skl_bind_unbind_modules() with argument rather than calling two APIs.

But yes I did look at the usage and can be removed

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]