All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Renesas ARM Based SoC Marzen Board Removal for v4.3
Date: Thu, 30 Jul 2015 00:21:36 +0000	[thread overview]
Message-ID: <20150730002136.GA3450@verge.net.au> (raw)
In-Reply-To: <20150727123327.GF14224@localhost>

Hi Olof,

On Mon, Jul 27, 2015 at 02:33:27PM +0200, Olof Johansson wrote:
> On Fri, Jul 24, 2015 at 05:41:47PM +0900, Simon Horman wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> > 
> > Please consider these Renesas ARM based SoC marzen board removal for v4.3.
> > 
> > This series removes legacy r8a7779 SoC and marzen board code.
> > It does so in a way that does not introduce feature regressions
> > when when booting the r8a7779/marzen board using shmobile_defconfig,
> > which provides for booting using multiplatform, a scenario which previously
> > used board code to provide some features including SMP.
> > 
> > Because of the above this series modifies SoC and DT files,
> > and then removes code. And because of that it was not entirely clear to
> > me which branch it should go into, so I have provided it in a stand-alone
> > branch.
> > 
> > Unfortunately this branch has a number of minor conflicts with the "Renesas
> > ARM Based SoC Cleanup for v4.3", tagged as renesas-cleanup-for-v4.3, which
> > you have previously pulled.
> > 
> > A resolution to those conflicts can be found in the
> > renesas-next-20150724-v4.2-rc1 tag of the renesas tree.
> > 
> > I would be happy to rebase these patches on top of renesas-cleanup-for-v4.3
> > and resubmit a conflict-free pull request if you like.
> > 
> > On a more positive note, I believe this to well over 8000 lines of legacy
> > code removed in this cycle :)
> 
> Organization is OK since the additions were small. If there were more
> additions needed, doing the enablement one release and removing the
> legacy code the release after would make more sense. But here that's fine.
> 
> The only thing I'd like to see different is to please send the defconfig
> updates separately. They just take out no-longer-existent entries anyway, so
> the series should do fine without them here.
> 
> So, please respin without the defconfig updates and provide them
> separately, if you want to avoid bisectability problems just do them
> next release.

Understood.

I am fine with breaking out the following, most likely deferring them to
the next release as I am concerned about bisectability:

* ARM: multi_v7_defconfig: Remove Marzen
* ARM: shmobile: Remove Marzen from shmobile_defconfig

There is another defconfig change, which I will resubmit in the
defconfig branch for this release.

* ARM: shmobile: Enable fixed voltage regulator in shmobile_defconfig

Without the above a number of devices do not function.

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Renesas ARM Based SoC Marzen Board Removal for v4.3
Date: Thu, 30 Jul 2015 09:21:36 +0900	[thread overview]
Message-ID: <20150730002136.GA3450@verge.net.au> (raw)
In-Reply-To: <20150727123327.GF14224@localhost>

Hi Olof,

On Mon, Jul 27, 2015 at 02:33:27PM +0200, Olof Johansson wrote:
> On Fri, Jul 24, 2015 at 05:41:47PM +0900, Simon Horman wrote:
> > Hi Olof, Hi Kevin, Hi Arnd,
> > 
> > Please consider these Renesas ARM based SoC marzen board removal for v4.3.
> > 
> > This series removes legacy r8a7779 SoC and marzen board code.
> > It does so in a way that does not introduce feature regressions
> > when when booting the r8a7779/marzen board using shmobile_defconfig,
> > which provides for booting using multiplatform, a scenario which previously
> > used board code to provide some features including SMP.
> > 
> > Because of the above this series modifies SoC and DT files,
> > and then removes code. And because of that it was not entirely clear to
> > me which branch it should go into, so I have provided it in a stand-alone
> > branch.
> > 
> > Unfortunately this branch has a number of minor conflicts with the "Renesas
> > ARM Based SoC Cleanup for v4.3", tagged as renesas-cleanup-for-v4.3, which
> > you have previously pulled.
> > 
> > A resolution to those conflicts can be found in the
> > renesas-next-20150724-v4.2-rc1 tag of the renesas tree.
> > 
> > I would be happy to rebase these patches on top of renesas-cleanup-for-v4.3
> > and resubmit a conflict-free pull request if you like.
> > 
> > On a more positive note, I believe this to well over 8000 lines of legacy
> > code removed in this cycle :)
> 
> Organization is OK since the additions were small. If there were more
> additions needed, doing the enablement one release and removing the
> legacy code the release after would make more sense. But here that's fine.
> 
> The only thing I'd like to see different is to please send the defconfig
> updates separately. They just take out no-longer-existent entries anyway, so
> the series should do fine without them here.
> 
> So, please respin without the defconfig updates and provide them
> separately, if you want to avoid bisectability problems just do them
> next release.

Understood.

I am fine with breaking out the following, most likely deferring them to
the next release as I am concerned about bisectability:

* ARM: multi_v7_defconfig: Remove Marzen
* ARM: shmobile: Remove Marzen from shmobile_defconfig

There is another defconfig change, which I will resubmit in the
defconfig branch for this release.

* ARM: shmobile: Enable fixed voltage regulator in shmobile_defconfig

Without the above a number of devices do not function.

  reply	other threads:[~2015-07-30  0:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24  8:41 [GIT PULL] Renesas ARM Based SoC Marzen Board Removal for v4.3 Simon Horman
2015-07-24  8:41 ` Simon Horman
2015-07-24  8:41 ` [PATCH 1/9] ARM: shmobile: r8a7779: Generic CCF and timer support Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 2/9] ARM: shmobile: r8a7779: Generic SMP ops Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 3/9] ARM: shmobile: Enable fixed voltage regulator in shmobile_defconfig Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 4/9] ARM: shmobile: marzen-reference: Remove C board code Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 5/9] ARM: shmobile: r8a7779: Cleanup header file Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 6/9] ARM: shmobile: Remove Marzen from shmobile_defconfig Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 7/9] ARM: multi_v7_defconfig: Remove Marzen Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 8/9] ARM: shmobile: marzen: Remove legacy board code Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-24  8:41 ` [PATCH 9/9] ARM: shmobile: r8a7779: Remove legacy SoC code Simon Horman
2015-07-24  8:41   ` Simon Horman
2015-07-27 12:33 ` [GIT PULL] Renesas ARM Based SoC Marzen Board Removal for v4.3 Olof Johansson
2015-07-27 12:33   ` Olof Johansson
2015-07-30  0:21   ` Simon Horman [this message]
2015-07-30  0:21     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730002136.GA3450@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.