From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp-shell: add documentation
Date: Thu, 30 Jul 2015 10:48:24 -0400 [thread overview]
Message-ID: <20150730104824.1e87989d@redhat.com> (raw)
In-Reply-To: <87615biaux.fsf@blackfin.pond.sub.org>
On Thu, 23 Jul 2015 09:36:38 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> John Snow <jsnow@redhat.com> writes:
>
> > On 07/02/2015 11:31 AM, Luiz Capitulino wrote:
> >> On Wed, 1 Jul 2015 14:25:49 -0400
> >> John Snow <jsnow@redhat.com> wrote:
> >>
> >>> I should probably document the changes that were made.
>
> John, what do you mean here?
>
> >>> Signed-off-by: John Snow <jsnow@redhat.com>
> >>
> >> Looks good to me, CC'ing maintainer.
>
> Luiz, is this a R-by?
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
This one is :)
>
> > Whoops, didn't realize Markus took this file over, too. Sorry Luiz.
>
> Don't worry about our maintainer reshuffling.
>
> > Markus, would you consider staging this? It's purely a documentation
> > update for only a dev tool, so it doesn't really matter /when/ it lands
> > either way, just shoring up some changes I made a while back to the
> > interpreter here.
> >
> > tldr: "ping"
>
> I'm happy to include this in the next pull after it got reviewed. I'm
> ignorant about qmp-shell, because I don't use it myself, so I'd have to
> dig through it to verify your documentation is accurate and reasonably
> complete.
>
> Fishing for more qualified reviewers:
>
> $ scripts/get_maintainer.pl --git-blame -f scripts/qmp/qmp-shell
> Markus Armbruster <armbru@redhat.com> (supporter:QMP)
> Luiz Capitulino <lcapitulino@redhat.com> (authored lines:230/390=59%,commits:10/10=100%)
> John Snow <jsnow@redhat.com> (authored lines:117/390=30%,commits:4/10=40%)
> "Daniel P. Berrange" <berrange@redhat.com> (authored lines:27/390=7%)
> Eric Blake <eblake@redhat.com> (commits:6/10=60%)
> Stefan Hajnoczi <stefanha@redhat.com> (commits:2/10=20%)
> Benoit Canet <benoit@irqsave.net> (commits:1/10=10%)
>
> Luiz, can you review for accuracy and reasonable completeness?
>
> Of course, I'm the reviewer of last resort for anything I maintain,
> whether I understand it or not :)
>
WARNING: multiple messages have this Message-ID (diff)
From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp-shell: add documentation
Date: Thu, 30 Jul 2015 10:48:24 -0400 [thread overview]
Message-ID: <20150730104824.1e87989d@redhat.com> (raw)
In-Reply-To: <87615biaux.fsf@blackfin.pond.sub.org>
On Thu, 23 Jul 2015 09:36:38 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> John Snow <jsnow@redhat.com> writes:
>
> > On 07/02/2015 11:31 AM, Luiz Capitulino wrote:
> >> On Wed, 1 Jul 2015 14:25:49 -0400
> >> John Snow <jsnow@redhat.com> wrote:
> >>
> >>> I should probably document the changes that were made.
>
> John, what do you mean here?
>
> >>> Signed-off-by: John Snow <jsnow@redhat.com>
> >>
> >> Looks good to me, CC'ing maintainer.
>
> Luiz, is this a R-by?
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
This one is :)
>
> > Whoops, didn't realize Markus took this file over, too. Sorry Luiz.
>
> Don't worry about our maintainer reshuffling.
>
> > Markus, would you consider staging this? It's purely a documentation
> > update for only a dev tool, so it doesn't really matter /when/ it lands
> > either way, just shoring up some changes I made a while back to the
> > interpreter here.
> >
> > tldr: "ping"
>
> I'm happy to include this in the next pull after it got reviewed. I'm
> ignorant about qmp-shell, because I don't use it myself, so I'd have to
> dig through it to verify your documentation is accurate and reasonably
> complete.
>
> Fishing for more qualified reviewers:
>
> $ scripts/get_maintainer.pl --git-blame -f scripts/qmp/qmp-shell
> Markus Armbruster <armbru@redhat.com> (supporter:QMP)
> Luiz Capitulino <lcapitulino@redhat.com> (authored lines:230/390=59%,commits:10/10=100%)
> John Snow <jsnow@redhat.com> (authored lines:117/390=30%,commits:4/10=40%)
> "Daniel P. Berrange" <berrange@redhat.com> (authored lines:27/390=7%)
> Eric Blake <eblake@redhat.com> (commits:6/10=60%)
> Stefan Hajnoczi <stefanha@redhat.com> (commits:2/10=20%)
> Benoit Canet <benoit@irqsave.net> (commits:1/10=10%)
>
> Luiz, can you review for accuracy and reasonable completeness?
>
> Of course, I'm the reviewer of last resort for anything I maintain,
> whether I understand it or not :)
>
next prev parent reply other threads:[~2015-07-30 14:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 18:25 [Qemu-trivial] [PATCH] qmp-shell: add documentation John Snow
2015-07-01 18:25 ` [Qemu-devel] " John Snow
2015-07-02 15:31 ` [Qemu-trivial] " Luiz Capitulino
2015-07-02 15:31 ` [Qemu-devel] " Luiz Capitulino
2015-07-07 16:33 ` [Qemu-trivial] " John Snow
2015-07-07 16:33 ` John Snow
2015-07-23 7:36 ` [Qemu-trivial] " Markus Armbruster
2015-07-23 7:36 ` Markus Armbruster
2015-07-27 3:30 ` [Qemu-trivial] " John Snow
2015-07-27 3:30 ` John Snow
2015-07-27 21:59 ` [Qemu-trivial] " Eric Blake
2015-07-27 21:59 ` Eric Blake
2015-07-30 14:48 ` Luiz Capitulino [this message]
2015-07-30 14:48 ` Luiz Capitulino
2015-08-05 9:49 ` [Qemu-trivial] " Markus Armbruster
2015-08-05 9:49 ` Markus Armbruster
2015-07-28 7:51 ` [Qemu-trivial] " Kashyap Chamarthy
2015-07-28 7:51 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730104824.1e87989d@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.