From: joeyli <jlee-IBi9RG/b67k@public.gmane.org>
To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
Cc: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
"Lee,
Chun-Yi" <joeyli.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address
Date: Thu, 30 Jul 2015 21:39:47 +0800 [thread overview]
Message-ID: <20150730133947.GN15651@linux-rxt1.site> (raw)
In-Reply-To: <20150730131723.GG2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
On Thu, Jul 30, 2015 at 02:17:23PM +0100, Matt Fleming wrote:
> On Thu, 30 Jul, at 08:31:16PM, joeyli wrote:
> >
> > I think hibernate overwrite it.
>
> We absolutely must get a more detailed answer before going any further.
>
> Simply put, if we're remapping the EFI regions into the virtual address
> space and calling SetVirtualAddressMap() on hibernate resume there is no
> reason that anyone should be using the old mappings.
>
> And since you've demonstrated that we *are* using the old mappings,
> we've likely got a bug somewhere that we need to get a handle on before
> we paper over the issue.
>
> Where exactly is the old mapping address being used? Is it that
> efi.systab->runtime->get_variable is incorrect? If you could paste the
> disassembled output where the page fault occurs, that would be helpful.
>
> --
> Matt Fleming, Intel Open Source Technology Center
OK, understood! Thanks for your suggestion!
But, I have a question about mapping Boot Code/Data to -4G area. I understand
we need Runtime regions, and 1:1 mapping is the workaround of some buggy BIOS.
But why should kernel mapping Boot regions to -4G area?
Thanks a lot!
Joey Lee
WARNING: multiple messages have this Message-ID (diff)
From: joeyli <jlee@suse.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
"Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address
Date: Thu, 30 Jul 2015 21:39:47 +0800 [thread overview]
Message-ID: <20150730133947.GN15651@linux-rxt1.site> (raw)
In-Reply-To: <20150730131723.GG2725@codeblueprint.co.uk>
On Thu, Jul 30, 2015 at 02:17:23PM +0100, Matt Fleming wrote:
> On Thu, 30 Jul, at 08:31:16PM, joeyli wrote:
> >
> > I think hibernate overwrite it.
>
> We absolutely must get a more detailed answer before going any further.
>
> Simply put, if we're remapping the EFI regions into the virtual address
> space and calling SetVirtualAddressMap() on hibernate resume there is no
> reason that anyone should be using the old mappings.
>
> And since you've demonstrated that we *are* using the old mappings,
> we've likely got a bug somewhere that we need to get a handle on before
> we paper over the issue.
>
> Where exactly is the old mapping address being used? Is it that
> efi.systab->runtime->get_variable is incorrect? If you could paste the
> disassembled output where the page fault occurs, that would be helpful.
>
> --
> Matt Fleming, Intel Open Source Technology Center
OK, understood! Thanks for your suggestion!
But, I have a question about mapping Boot Code/Data to -4G area. I understand
we need Runtime regions, and 1:1 mapping is the workaround of some buggy BIOS.
But why should kernel mapping Boot regions to -4G area?
Thanks a lot!
Joey Lee
next prev parent reply other threads:[~2015-07-30 13:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 4:32 [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address Lee, Chun-Yi
2015-07-30 4:32 ` Lee, Chun-Yi
[not found] ` <1438230757-30840-1-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2015-07-30 7:53 ` H. Peter Anvin
2015-07-30 7:53 ` H. Peter Anvin
[not found] ` <55B9D806.7030705-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2015-07-30 8:03 ` Borislav Petkov
2015-07-30 8:03 ` Borislav Petkov
[not found] ` <20150730080323.GD8984-K5JNixvcfoxupOikMc4+xw@public.gmane.org>
2015-07-30 10:11 ` Matt Fleming
2015-07-30 10:11 ` Matt Fleming
[not found] ` <20150730101131.GB2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-30 11:09 ` joeyli
2015-07-30 11:09 ` joeyli
[not found] ` <20150730110959.GJ15651-empE8CJ7fzk2xCFIczX1Fw@public.gmane.org>
2015-07-30 11:18 ` joeyli
2015-07-30 11:18 ` joeyli
[not found] ` <20150730111819.GK15651-empE8CJ7fzk2xCFIczX1Fw@public.gmane.org>
2015-07-30 12:09 ` Matt Fleming
2015-07-30 12:09 ` Matt Fleming
[not found] ` <20150730120916.GD2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-30 12:31 ` joeyli
2015-07-30 12:31 ` joeyli
2015-07-30 13:17 ` Matt Fleming
[not found] ` <20150730131723.GG2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-30 13:39 ` joeyli [this message]
2015-07-30 13:39 ` joeyli
2015-07-30 14:05 ` Matt Fleming
[not found] ` <20150730140542.GI2725-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-07-30 14:16 ` joeyli
2015-07-30 14:16 ` joeyli
2015-08-19 16:31 ` Matt Fleming
2015-08-20 1:05 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730133947.GN15651@linux-rxt1.site \
--to=jlee-ibi9rg/b67k@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=joeyli.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.