From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
rob.herring@linaro.org, arnd.bergmann@linaro.org, nm@ti.com,
broonie@kernel.org, mturquette@baylibre.com,
Sudeep.Holla@arm.com, viswanath.puttagunta@linaro.org,
l.stach@pengutronix.de, thomas.petazzoni@free-electrons.com,
linux-arm-kernel@lists.infradead.org, ta.omasab@gmail.com,
kesavan.abhilash@gmail.com, khilman@linaro.org,
santosh.shilimkar@oracle.com, b.zolnierkie@samsung.com,
Tomasz Figa <tomasz.figa@gmail.com>,
Javier Martinez Canillas <javier@dowhile0.org>,
Thomas Abraham <thomas.ab@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is_turbo() helper
Date: Thu, 30 Jul 2015 23:10:23 -0700 [thread overview]
Message-ID: <20150731061023.GL3159@codeaurora.org> (raw)
In-Reply-To: <1e1445bc7f79eb4adc5bf1a0f5eddf118dc60345.1438166099.git.viresh.kumar@linaro.org>
On 07/29, Viresh Kumar wrote:
> +bool dev_pm_opp_is_turbo(struct dev_pm_opp *opp)
> +{
> + struct dev_pm_opp *tmp_opp;
> +
> + opp_rcu_lockdep_assert();
> +
> + tmp_opp = rcu_dereference(opp);
> + if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) {
IS_ERR_OR_NULL already has unlikely inside it on the error
pointer path so it seems redundant here.
Otherwise
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is_turbo() helper
Date: Thu, 30 Jul 2015 23:10:23 -0700 [thread overview]
Message-ID: <20150731061023.GL3159@codeaurora.org> (raw)
In-Reply-To: <1e1445bc7f79eb4adc5bf1a0f5eddf118dc60345.1438166099.git.viresh.kumar@linaro.org>
On 07/29, Viresh Kumar wrote:
> +bool dev_pm_opp_is_turbo(struct dev_pm_opp *opp)
> +{
> + struct dev_pm_opp *tmp_opp;
> +
> + opp_rcu_lockdep_assert();
> +
> + tmp_opp = rcu_dereference(opp);
> + if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) {
IS_ERR_OR_NULL already has unlikely inside it on the error
pointer path so it seems redundant here.
Otherwise
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-07-31 6:10 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 10:52 [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-29 10:52 ` [PATCH V3 01/16] PM / OPP: Update bindings to make opp-hz a 64 bit value Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
[not found] ` <f87ca786bca8abce6261dbd79a34218550355684.1438166099.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-30 13:23 ` Rob Herring
2015-07-30 13:23 ` Rob Herring
2015-07-30 13:23 ` Rob Herring
2015-07-29 10:52 ` [PATCH V3 02/16] PM / OPP: Create a directory for opp bindings Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-30 13:18 ` Rob Herring
2015-07-30 13:18 ` Rob Herring
2015-07-30 13:49 ` Viresh Kumar
2015-07-30 13:49 ` Viresh Kumar
2015-07-30 16:24 ` Rob Herring
2015-07-30 16:24 ` Rob Herring
2015-07-30 16:52 ` Viresh Kumar
2015-07-30 16:52 ` Viresh Kumar
2015-07-30 16:57 ` [PATCH V3 resend] " Viresh Kumar
2015-07-30 16:57 ` Viresh Kumar
2015-07-29 10:52 ` [PATCH V3 03/16] PM / OPP: Relocate few routines Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-29 10:52 ` [PATCH V3 04/16] PM / OPP: Create _remove_device_opp() for freeing dev_opp Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-29 10:52 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 05/16] PM / OPP: Allocate dev_opp from _add_device_opp() Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 06/16] PM / OPP: Break _opp_add_dynamic() into smaller functions Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 5:43 ` Stephen Boyd
2015-07-31 5:43 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 07/16] PM / OPP: Add support to parse "operating-points-v2" bindings Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 5:51 ` Stephen Boyd
2015-07-31 5:51 ` Stephen Boyd
2015-07-31 5:58 ` Viresh Kumar
2015-07-31 5:58 ` Viresh Kumar
2015-07-31 6:20 ` Stephen Boyd
2015-07-31 6:20 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 08/16] PM / OPP: Add clock-latency-ns support Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 09/16] PM / OPP: Add OPP sharing information to OPP library Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 10/16] PM / OPP: Add support for opp-suspend Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:24 ` Stephen Boyd
2015-07-31 6:24 ` Stephen Boyd
2015-07-31 6:26 ` Viresh Kumar
2015-07-31 6:26 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 11/16] PM / OPP: Add helpers for initializing CPU OPPs Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:07 ` Stephen Boyd
2015-07-31 6:07 ` Stephen Boyd
2015-07-31 6:13 ` Viresh Kumar
2015-07-31 6:13 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is_turbo() helper Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:10 ` Stephen Boyd [this message]
2015-07-31 6:10 ` Stephen Boyd
2015-07-31 6:17 ` Viresh Kumar
2015-07-31 6:17 ` Viresh Kumar
2015-07-29 10:53 ` [PATCH V3 13/16] cpufreq: Update boost flag while initializing freq table from OPPs Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:11 ` Stephen Boyd
2015-07-31 6:11 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 14/16] cpufreq: Allow drivers to enable boost support after registering driver Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:12 ` Stephen Boyd
2015-07-31 6:12 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 15/16] cpufreq: dt: Add support for operating-points-v2 bindings Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:15 ` Stephen Boyd
2015-07-31 6:15 ` Stephen Boyd
2015-07-29 10:53 ` [PATCH V3 16/16] cpufreq: dt: Add support for turbo/boost mode Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-29 10:53 ` Viresh Kumar
2015-07-31 6:16 ` Stephen Boyd
2015-07-31 6:16 ` Stephen Boyd
2015-07-31 18:55 ` [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings Bartlomiej Zolnierkiewicz
2015-07-31 18:55 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731061023.GL3159@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Sudeep.Holla@arm.com \
--cc=arnd.bergmann@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=kesavan.abhilash@gmail.com \
--cc=khilman@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@linaro.org \
--cc=santosh.shilimkar@oracle.com \
--cc=ta.omasab@gmail.com \
--cc=thomas.ab@samsung.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tomasz.figa@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=viswanath.puttagunta@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.