All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4/8] x86/vm86: Use the normal pt_regs area for vm86
Date: Fri, 31 Jul 2015 11:12:26 +0200	[thread overview]
Message-ID: <20150731091226.GA21116@gmail.com> (raw)
In-Reply-To: <1438148483-11932-5-git-send-email-brgerst@gmail.com>


* Brian Gerst <brgerst@gmail.com> wrote:

> --- a/arch/x86/include/asm/vm86.h
> +++ b/arch/x86/include/asm/vm86.h

> +static inline void save_v86_state(struct kernel_vm86_regs *, int) { }
> +

So this is not a valid inline function and the patches were clearly not built with 
!VM86 such as 64-bit defconfig:

 In file included from arch/x86/kernel/signal.c:34:0:
 ./arch/x86/include/asm/vm86.h: In function ‘save_v86_state’:
 ./arch/x86/include/asm/vm86.h:70:42: error: parameter name omitted
  static inline void save_v86_state(struct kernel_vm86_regs *, int) { }
 ./arch/x86/include/asm/vm86.h:70:42: error: parameter name omitted

I fixed this up.

Thanks,

	Ingo

  parent reply	other threads:[~2015-07-31  9:12 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29  5:41 [PATCH v4] x86: vm86 cleanups Brian Gerst
2015-07-29  5:41 ` [PATCH 1/8] x86/vm86: Move vm86 fields out of thread_struct Brian Gerst
2015-07-29 15:24   ` Andy Lutomirski
2015-07-31 14:03   ` [tip:x86/asm] x86/vm86: Move vm86 fields out of 'thread_struct' tip-bot for Brian Gerst
2015-07-29  5:41 ` [PATCH 2/8] x86/vm86: Move fields from kernel_vm86_struct Brian Gerst
2015-07-29 15:32   ` Andy Lutomirski
2015-07-31 14:03   ` [tip:x86/asm] x86/vm86: Move fields from ' struct kernel_vm86_struct' to 'struct vm86' tip-bot for Brian Gerst
2015-07-29  5:41 ` [PATCH 3/8] x86/vm86: Eliminate kernel_vm86_struct Brian Gerst
2015-07-29 15:33   ` Andy Lutomirski
2015-07-31 14:03   ` [tip:x86/asm] x86/vm86: Eliminate 'struct kernel_vm86_struct' tip-bot for Brian Gerst
2015-07-29  5:41 ` [PATCH 4/8] x86/vm86: Use the normal pt_regs area for vm86 Brian Gerst
2015-07-29 15:50   ` Andy Lutomirski
2015-07-29 17:14     ` Brian Gerst
2015-07-29 17:16       ` Linus Torvalds
2015-07-29 17:36         ` Brian Gerst
2015-07-29 17:47           ` Linus Torvalds
2015-07-29 17:50             ` Andy Lutomirski
2015-07-31  9:12   ` Ingo Molnar [this message]
2015-07-31  9:17     ` Ingo Molnar
2015-07-31  9:47       ` Ingo Molnar
2015-07-31 12:14         ` Brian Gerst
2015-07-31 14:03   ` [tip:x86/asm] " tip-bot for Brian Gerst
2015-07-29  5:41 ` [PATCH 5/8] x86/vm86: Add a separate config option for hardware IRQ handling Brian Gerst
2015-07-31  8:57   ` Ingo Molnar
2015-07-31 12:10     ` Brian Gerst
2015-07-31 13:50       ` Ingo Molnar
2015-07-31 13:59         ` Brian Gerst
2015-08-05  8:51           ` Ingo Molnar
2015-07-31 14:04   ` [tip:x86/asm] x86/vm86: Move the vm86 IRQ definitions to vm86.h tip-bot for Ingo Molnar
2015-07-29  5:41 ` [PATCH 6/8] x86/vm86: Clean up vm86.h includes Brian Gerst
2015-07-31 14:04   ` [tip:x86/asm] " tip-bot for Brian Gerst
2015-07-31 14:53     ` Brian Gerst
2015-08-01  8:22       ` Ingo Molnar
2015-07-29  5:41 ` [PATCH 7/8] x86/vm86: Rename vm86->vm86_info to user_vm86 Brian Gerst
2015-07-31 14:04   ` [tip:x86/asm] " tip-bot for Brian Gerst
2015-07-29  5:41 ` [PATCH 8/8] x86/vm86: Rename vm86->v86flags and v86mask Brian Gerst
2015-07-31 14:05   ` [tip:x86/asm] " tip-bot for Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150731091226.GA21116@gmail.com \
    --to=mingo@kernel.org \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.