From: Ingo Molnar <mingo@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 5/8] x86/vm86: Add a separate config option for hardware IRQ handling
Date: Wed, 5 Aug 2015 10:51:27 +0200 [thread overview]
Message-ID: <20150805085126.GB23169@gmail.com> (raw)
In-Reply-To: <CAMzpN2gyjWC0obJtJHrA76jtUjYVNqhNHfpiURPkZ=ogOBCHFA@mail.gmail.com>
* Brian Gerst <brgerst@gmail.com> wrote:
> >> Disabling even less-used code that could have system stability impact. We've
> >> discouraged user-mode drivers for a very long time. Ironically, other than
> >> being configured through the vm86 syscall, there isn't really anything
> >> vm86-specific about it. All it does is register an IRQ handler that sends a
> >> signal to the task.
> >
> > So is this actually used by anything? Could we get away with disabling it,
> > just to see whether anything cares?
>
> My best guess would be some very old X11 drivers that needed interrupts to run
> the Video BIOS code.
So let's keep it - but not complicate it with another layer of disabling logic.
People that rely on legacies will enable vm86 as a single block - they won't
necessarily know how deeply they rely on it.
What _would_ be useful is to have a 3-mode vm86 sysctl:
1: enabled
0: disabled
-1: disabled permanently (one-shot disabling after bootup)
That way a distro can permanently disable vm86 for a particular bootup by setting
it to -1 in /etc/sysctl.conf.
The kernel should default that setting to '0'.
Thanks,
Ingo
next prev parent reply other threads:[~2015-08-05 8:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 5:41 [PATCH v4] x86: vm86 cleanups Brian Gerst
2015-07-29 5:41 ` [PATCH 1/8] x86/vm86: Move vm86 fields out of thread_struct Brian Gerst
2015-07-29 15:24 ` Andy Lutomirski
2015-07-31 14:03 ` [tip:x86/asm] x86/vm86: Move vm86 fields out of 'thread_struct' tip-bot for Brian Gerst
2015-07-29 5:41 ` [PATCH 2/8] x86/vm86: Move fields from kernel_vm86_struct Brian Gerst
2015-07-29 15:32 ` Andy Lutomirski
2015-07-31 14:03 ` [tip:x86/asm] x86/vm86: Move fields from ' struct kernel_vm86_struct' to 'struct vm86' tip-bot for Brian Gerst
2015-07-29 5:41 ` [PATCH 3/8] x86/vm86: Eliminate kernel_vm86_struct Brian Gerst
2015-07-29 15:33 ` Andy Lutomirski
2015-07-31 14:03 ` [tip:x86/asm] x86/vm86: Eliminate 'struct kernel_vm86_struct' tip-bot for Brian Gerst
2015-07-29 5:41 ` [PATCH 4/8] x86/vm86: Use the normal pt_regs area for vm86 Brian Gerst
2015-07-29 15:50 ` Andy Lutomirski
2015-07-29 17:14 ` Brian Gerst
2015-07-29 17:16 ` Linus Torvalds
2015-07-29 17:36 ` Brian Gerst
2015-07-29 17:47 ` Linus Torvalds
2015-07-29 17:50 ` Andy Lutomirski
2015-07-31 9:12 ` Ingo Molnar
2015-07-31 9:17 ` Ingo Molnar
2015-07-31 9:47 ` Ingo Molnar
2015-07-31 12:14 ` Brian Gerst
2015-07-31 14:03 ` [tip:x86/asm] " tip-bot for Brian Gerst
2015-07-29 5:41 ` [PATCH 5/8] x86/vm86: Add a separate config option for hardware IRQ handling Brian Gerst
2015-07-31 8:57 ` Ingo Molnar
2015-07-31 12:10 ` Brian Gerst
2015-07-31 13:50 ` Ingo Molnar
2015-07-31 13:59 ` Brian Gerst
2015-08-05 8:51 ` Ingo Molnar [this message]
2015-07-31 14:04 ` [tip:x86/asm] x86/vm86: Move the vm86 IRQ definitions to vm86.h tip-bot for Ingo Molnar
2015-07-29 5:41 ` [PATCH 6/8] x86/vm86: Clean up vm86.h includes Brian Gerst
2015-07-31 14:04 ` [tip:x86/asm] " tip-bot for Brian Gerst
2015-07-31 14:53 ` Brian Gerst
2015-08-01 8:22 ` Ingo Molnar
2015-07-29 5:41 ` [PATCH 7/8] x86/vm86: Rename vm86->vm86_info to user_vm86 Brian Gerst
2015-07-31 14:04 ` [tip:x86/asm] " tip-bot for Brian Gerst
2015-07-29 5:41 ` [PATCH 8/8] x86/vm86: Rename vm86->v86flags and v86mask Brian Gerst
2015-07-31 14:05 ` [tip:x86/asm] " tip-bot for Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805085126.GB23169@gmail.com \
--to=mingo@kernel.org \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.