Re: [PATCH 0/8] i2c: img-scb: fixes to support i2c on pistachio

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]

On Mon, Jul 27, 2015 at 12:47:13PM +0100, Sifan Naeem wrote:
> Following patches are required to fix the existing driver to
> support i2c on pistachio.
> 
> Tested on Pistachio bub using an Adafruit I2C Non-Volatile FRAM Breakout
> (256Kbit / 32KByte) eeprom.
> 
> Used i2c buildroot tools to test the eeprom and the other i2c blocks.
> Also used dd commands to copy data to and then to dump data from the
> eeprom. i2ctransfer was used to test repeated starts and verified
> using a scope.

That sounds like good testing \o/ If you are happy with i2ctransfer,
then please consider adding Tested-by tags to the i2ctransfer patches,
so Jean gets a more cosy feeling to include them to i2ctools.

> 
> Cc: Stable kernel (v3.19+) <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>

I am happy for indications like "please consider adding this line for
stable: ...", but not CC stable yourself. These patches need changes,
so they are noise for the stable lists. The ones I ultimately apply are
the proper ones.

That being said, I'll mark all your patches "changes reqeuested" since you
need to resend based on current review from James (thanks a lot!). Even
if some patches are good and got acked, but it is easier for me to mark
them all the same :)

> 
> Sifan Naeem (8):
>   i2c: img-scb: enable fencing for all versions of the ip
>   i2c: img-scb: do dummy writes before fifo access
>   i2c: img-scb: use DIV_ROUND_UP to round divisor values
>   i2c: img-scb: fix LOW and HIGH period values for the SCL clock
>   i2c: img-scb: reset interrupts in img_i2c_soft_reset
>   i2c: img-scb: remove start bit detected status after handling
>   i2c: img-scb: improve transaction complete handle
>   i2c: img-scb: verify support for requested bit rate
> 
>  drivers/i2c/busses/i2c-img-scb.c |  101 ++++++++++++++++++++++----------------
>  1 file changed, 58 insertions(+), 43 deletions(-)
> 
> -- 
> 1.7.9.5
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]