From: Ralf Baechle <ralf@linux-mips.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Andre Przywara <andre.przywara@arm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Borislav Petkov <bp@suse.de>,
linux-arm-kernel@l
Subject: Re: [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire
Date: Mon, 3 Aug 2015 08:02:17 +0200 [thread overview]
Message-ID: <20150803060217.GB16650@linux-mips.org> (raw)
In-Reply-To: <1438528264-714-1-git-send-email-andreyknvl@google.com>
On Sun, Aug 02, 2015 at 05:11:04PM +0200, Andrey Konovalov wrote:
> diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h
> index 7ecba84..752e0b8 100644
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -133,12 +133,12 @@
> do { \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> - ACCESS_ONCE(*p) = (v); \
> + WRITE_ONCE(*p, v); \
> } while (0)
>
> #define smp_load_acquire(p) \
> ({ \
> - typeof(*p) ___p1 = ACCESS_ONCE(*p); \
> + typeof(*p) ___p1 = READ_ONCE(*p); \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> ___p1; \
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Andre Przywara <andre.przywara@arm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Borislav Petkov <bp@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire
Date: Mon, 3 Aug 2015 08:02:17 +0200 [thread overview]
Message-ID: <20150803060217.GB16650@linux-mips.org> (raw)
Message-ID: <20150803060217.JKv9E4-4Pv1xbaeXtcwpl4gD2iMEC4baqx9MFgXhjSc@z> (raw)
In-Reply-To: <1438528264-714-1-git-send-email-andreyknvl@google.com>
On Sun, Aug 02, 2015 at 05:11:04PM +0200, Andrey Konovalov wrote:
> diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h
> index 7ecba84..752e0b8 100644
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -133,12 +133,12 @@
> do { \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> - ACCESS_ONCE(*p) = (v); \
> + WRITE_ONCE(*p, v); \
> } while (0)
>
> #define smp_load_acquire(p) \
> ({ \
> - typeof(*p) ___p1 = ACCESS_ONCE(*p); \
> + typeof(*p) ___p1 = READ_ONCE(*p); \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> ___p1; \
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Andre Przywara <andre.przywara@arm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Borislav Petkov <bp@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire
Date: Mon, 03 Aug 2015 06:02:17 +0000 [thread overview]
Message-ID: <20150803060217.GB16650@linux-mips.org> (raw)
In-Reply-To: <1438528264-714-1-git-send-email-andreyknvl@google.com>
On Sun, Aug 02, 2015 at 05:11:04PM +0200, Andrey Konovalov wrote:
> diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h
> index 7ecba84..752e0b8 100644
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -133,12 +133,12 @@
> do { \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> - ACCESS_ONCE(*p) = (v); \
> + WRITE_ONCE(*p, v); \
> } while (0)
>
> #define smp_load_acquire(p) \
> ({ \
> - typeof(*p) ___p1 = ACCESS_ONCE(*p); \
> + typeof(*p) ___p1 = READ_ONCE(*p); \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> ___p1; \
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
James Hogan <james.hogan@imgtec.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Andre Przywara <andre.przywara@arm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Borislav Petkov <bp@suse.de>,
linux-arm-kernel@l
Subject: Re: [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire
Date: Mon, 03 Aug 2015 06:02:17 +0000 [thread overview]
Message-ID: <20150803060217.GB16650@linux-mips.org> (raw)
In-Reply-To: <1438528264-714-1-git-send-email-andreyknvl@google.com>
On Sun, Aug 02, 2015 at 05:11:04PM +0200, Andrey Konovalov wrote:
> diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h
> index 7ecba84..752e0b8 100644
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -133,12 +133,12 @@
> do { \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> - ACCESS_ONCE(*p) = (v); \
> + WRITE_ONCE(*p, v); \
> } while (0)
>
> #define smp_load_acquire(p) \
> ({ \
> - typeof(*p) ___p1 = ACCESS_ONCE(*p); \
> + typeof(*p) ___p1 = READ_ONCE(*p); \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> ___p1; \
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: ralf@linux-mips.org (Ralf Baechle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire
Date: Mon, 3 Aug 2015 08:02:17 +0200 [thread overview]
Message-ID: <20150803060217.GB16650@linux-mips.org> (raw)
In-Reply-To: <1438528264-714-1-git-send-email-andreyknvl@google.com>
On Sun, Aug 02, 2015 at 05:11:04PM +0200, Andrey Konovalov wrote:
> diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h
> index 7ecba84..752e0b8 100644
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -133,12 +133,12 @@
> do { \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> - ACCESS_ONCE(*p) = (v); \
> + WRITE_ONCE(*p, v); \
> } while (0)
>
> #define smp_load_acquire(p) \
> ({ \
> - typeof(*p) ___p1 = ACCESS_ONCE(*p); \
> + typeof(*p) ___p1 = READ_ONCE(*p); \
> compiletime_assert_atomic_type(*p); \
> smp_mb(); \
> ___p1; \
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
next prev parent reply other threads:[~2015-08-03 6:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 15:11 [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire Andrey Konovalov
2015-08-02 15:11 ` Andrey Konovalov
2015-08-02 15:11 ` Andrey Konovalov
2015-08-02 16:08 ` Peter Zijlstra
2015-08-02 16:08 ` Peter Zijlstra
2015-08-02 16:08 ` Peter Zijlstra
2015-08-02 16:08 ` Peter Zijlstra
2015-08-02 16:08 ` Peter Zijlstra
2015-08-02 20:50 ` Davidlohr Bueso
2015-08-02 20:50 ` Davidlohr Bueso
2015-08-02 20:50 ` Davidlohr Bueso
2015-08-02 20:50 ` Davidlohr Bueso
2015-08-02 20:50 ` Davidlohr Bueso
2015-08-03 1:41 ` Michael Ellerman
2015-08-03 1:41 ` Michael Ellerman
2015-08-03 1:41 ` Michael Ellerman
2015-08-03 1:41 ` Michael Ellerman
2015-08-03 1:41 ` Michael Ellerman
2015-08-03 6:02 ` Ralf Baechle [this message]
2015-08-03 6:02 ` Ralf Baechle
2015-08-03 6:02 ` Ralf Baechle
2015-08-03 6:02 ` Ralf Baechle
2015-08-03 6:02 ` Ralf Baechle
2015-08-03 17:00 ` [tip:locking/core] locking, arch: use WRITE_ONCE()/READ_ONCE() in smp_store_release()/smp_load_acquire() tip-bot for Andrey Konovalov
-- strict thread matches above, loose matches on Subject: below --
2015-08-02 15:11 [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire Andrey Konovalov
2015-08-02 15:11 Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803060217.GB16650@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alexander.h.duyck@redhat.com \
--cc=andre.przywara@arm.com \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arm-kernel@l \
--cc=linux390@de.ibm.com \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.